Re: git: f9337e56a2e3 - main - nfsd: Make nfsrv_getstate() validate the stateid type

From: Mark Johnston <markj_at_freebsd.org>
Date: Wed, 18 Nov 2026 16:03:55 UTC
On Wed, Nov 18, 2026 at 08:43:37AM -0700, alan somers wrote:
> On Tue, Nov 17, 2026 at 10:02 AM Mark Johnston <markj@freebsd.org> wrote:
> >
> > The branch main has been updated by markj:
> >
> > URL: https://cgit.FreeBSD.org/src/commit/?id=f9337e56a2e3ba47b91272f1f3a8de6af6d27d5b
> >
> > commit f9337e56a2e3ba47b91272f1f3a8de6af6d27d5b
> > Author:     Rick Macklem <rmacklem@FreeBSD.org>
> > AuthorDate: 2026-11-12 17:19:03 +0000
> > Commit:     Mark Johnston <markj@FreeBSD.org>
> > CommitDate: 2026-11-17 16:57:00 +0000
> >
> >     nfsd: Make nfsrv_getstate() validate the stateid type
> >
> >     Otherwise nfsrv_delegupdate() can be tricked by a client into freeing a
> >     state when it shouldn't, resulting in a use-after-free.
> >
> >     Approved by:    so
> >     Security:       FreeBSD-SA-26:79.nfs
> >     Security:       CVE-2026-101317
> >     Reported by:    H. P. Cook <barry@unseen.sh>
> 
> If an NFSv4 server disables delegations by setting
> vfs.nfsd.issue_delegations=0, does that protect it from this
> vulnerability?

No, nfsrvd_delegreturn() handles the request regardless of whether
delegations are actually enabled on the server.