From nobody Wed Nov 18 16:03:55 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jV5xp3ZV3z6w25y; Wed, 18 Nov 2026 16:03:58 +0000 (UTC) (envelope-from markj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jV5xp2tMMz4Mwd; Wed, 18 Nov 2026 16:03:58 +0000 (UTC) (envelope-from markj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795017838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z6it2LmlVCZa/RvobuLv2TCTSjpgPHTok2/71/wnp/E=; b=Udvd09hMEzJf2mHIzeYkG95kBCEhxb8+BNLCzK79910LciqajT6UI7MugJOGCmlEl4j/Qz 3Kez0yTUxasWwKmtZN9NPRomCICHbR9pU0T7ny4bfzVh0/rBZWHfkMrK9etcuMxdJ2UzY+ qKMsGLcAIrqLhvTV3Ni4nkJ6/UzpgZKP4GmQZB0ExeO41m3TQS5JoKG26ouTu/6rO4aukd clth+mpR5sTzXLHCTjWaia4Fi9bsr1Cdl0za9/Qm5fx2iQTVky701RWvC0LcYviRER672e wXk1QVqRlWcfWu11Pe+ZGSJy7LqNI0Lh8iCfoDNuWTg61/xqM/swVUdXirJBDw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795017838; b=jlNHn5AXKvjKJAciKn7HzJp2Heu6zT/pXrPciuLKAZrXE8xLywCVRo+xZ+n+rRo4pW7waj aCjc8pOMwY5hh6XDxD3hzX7BTRZ8IXPKeO9acMrgwdwUcd/7gvo1w0kTxQ1udU5EireEbx I5xyJDxzIkR7hxk7CV0jmqD6rASWRBMcjZrywISIe2SHi2aHLdFfmwGeTuaVZxOZY4+1vO chibF5RHi+9vxkOAiZyaZB52JVFL6iFBSb5wkXV1ayeIIXNtJHpjaTb8jB0RIfgfiCUYZ7 XblS8ie6uPMxsDYVcTGMc9tmMDPoE/IwFKEKOTvACgKOJoIFdExuPgzUxzqyHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795017838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z6it2LmlVCZa/RvobuLv2TCTSjpgPHTok2/71/wnp/E=; b=fbAQSG3cXR+xiioPilrCNqYcxlOcWO8j3NJXXUX/HBpMzsnTUDv4lSYioJLQxKw4eh/fr6 KtTKs88YVoet7Div23z0pmaiPv5orxlUMIHugmEM4Ci6T7O5eQLcGltZ6zl/WZa9FQLL0k FjpuaXReh+nadmAkmxGys6eoMS/83Kv9SZrt1k9Hbhjrbl3CQGwWTBWhqd9v6SqijLqZpR sTpNF5k5GWsOdumarFMPoEGd9bmwCGH0zdG0p+gXOADbhOuASBHy1OMPuYHyXWGikiTAVU 0NFs2MKqTxgVjfS4c4dl8cISwz1HNbZpjBS5OQUVj4R8a5kvnXLD+gaFdr0kvg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from nuc (198-84-224-249.cpe.teksavvy.com [198.84.224.249]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: markj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4jV5xp0CvHzyBx; Wed, 18 Nov 2026 16:03:57 +0000 (UTC) (envelope-from markj@freebsd.org) Date: Wed, 18 Nov 2026 11:03:55 -0500 From: Mark Johnston To: alan somers Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Rick Macklem Subject: Re: git: f9337e56a2e3 - main - nfsd: Make nfsrv_getstate() validate the stateid type Message-ID: References: <6afc8874.1e307.2b6fa8c6@gitrepo.freebsd.org> List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Nov 18, 2026 at 08:43:37AM -0700, alan somers wrote: > On Tue, Nov 17, 2026 at 10:02 AM Mark Johnston wrote: > > > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=f9337e56a2e3ba47b91272f1f3a8de6af6d27d5b > > > > commit f9337e56a2e3ba47b91272f1f3a8de6af6d27d5b > > Author: Rick Macklem > > AuthorDate: 2026-11-12 17:19:03 +0000 > > Commit: Mark Johnston > > CommitDate: 2026-11-17 16:57:00 +0000 > > > > nfsd: Make nfsrv_getstate() validate the stateid type > > > > Otherwise nfsrv_delegupdate() can be tricked by a client into freeing a > > state when it shouldn't, resulting in a use-after-free. > > > > Approved by: so > > Security: FreeBSD-SA-26:79.nfs > > Security: CVE-2026-101317 > > Reported by: H. P. Cook > > If an NFSv4 server disables delegations by setting > vfs.nfsd.issue_delegations=0, does that protect it from this > vulnerability? No, nfsrvd_delegreturn() handles the request regardless of whether delegations are actually enabled on the server.