Re: git: 3a1f5a28f007 - main - proc.h: Order thread_lock*() functions more logically
Date: Mon, 16 Nov 2026 19:08:35 UTC
On 11/16/26 03:14, Olivier Certner wrote: >> The functions were ordered alphabetically, as it should be. > > No, they do not need to. In some places they are, mostly because of history or because nobody bothered to classify them. It is generally much more useful to group them by usage/category. Typically, functions that must be paired should be adjacent. Hmm, my understanding of style(9) from bde matches kib@ which is to sort alphabetically. That said, in practice I tend to do that within groups, that is if there is a group of related functions, I sort them alphabetically, but may use separate groups instead of one giant group if there are comments for the groups. -- John Baldwin