From nobody Mon Nov 16 19:08:35 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jSy7m1j5Dz70c6K; Mon, 16 Nov 2026 19:08:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jSy7m1CsQz4Yt0; Mon, 16 Nov 2026 19:08:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794856116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qR1D0eoB1pH3wNrd/Je5bGdvE5ArbArOr2Jurv/zi3w=; b=liOvAxjWpUD6gkcql/AHZHCpkz3XxzsxBIkZ8g0DNTQaOI/LDI2QGJusyXZ/W6XqWHOe0H +rRS/oP0qJPRZ2KdceWre53DsKdtZOlXbIG7bEIZDAj1XLWMF2voknWk2uU0hF7ftWJo5q IdNO7XCQdox4/cJATc44yFf1a/MZHIH50u8zY1aVvtx2mmvKz9i+hBog0DqOXC27n6UHcL tsfVfd/U/wHY6ejOd/fIGFT/4uqcGoYGJ/ehIQjzyXS0aeWx/OE40PjpB+GAX9f7a01ACZ DWP3z2kJHhUHl2dRh+r5IMDXoLVyVIHwYcU0Hyvi31Bx3sAp+Et8ZGwF90XT8A== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794856116; b=kYR9fWOs8QImg1imB/+WdAHTwqGo6qSfI2Kp7WV/D8ooqg3YmfwobCOgHdbIT/BLnZjolX iSfvpEaqOfcVNx9Blj+z/X3ri9Rp4yb29hx32CRI0WqZmwiu41xz4G0qtfCNKb8BVWibAK BZ1Q0LXjSoNP2lmDdGpEK1EFetZ+Qu3jRJeGp7lndnU14LvtkP3olOgb7LOFzd5u/6qwev maWt/Sk2firyf16agtP7BD9sTMany19sE/CJ4lN34RYnZPCIXgYAPSxmSJlCsoDaSlPXTM Qn/baX1CiBIa4ZN4tg28fDxgY3R7CcWz8cmgoswCpkp0PJKfwbxtFQ+L+nNYGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794856116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qR1D0eoB1pH3wNrd/Je5bGdvE5ArbArOr2Jurv/zi3w=; b=roD5VxNvHebEjKlUgvCbXDdObT/rR7AM7RmCpWLU1V9dFKQ0rfOy07B9D0n+w/+6NyCvBB LFTV335pArVgw1aF7dWC0INdCpcn6RRwmjEJ2UBzgXCQ76QjIoTkiHf1dacYKmlkkn3tsf H92eooh6HwQAnpM40aJRQF8EQkx5kC5Dxpe+MHKBdLZNNbIpGLRzFasM6VixJAKkBI/bB5 LFwIdmp9vvMk9xXP5d/rNGvaNJ8g5SJ/r1Ci1MnxibA7WgYeOTTkoBK4gsE0F5RIv5VFtH 8dceS06GvDqsblFEkNMFE9b/AOksM3v+3v6/gOZmuaOU82Kk+rwv/z35/a9Luw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:5cc:4480:1036:9488:4058:41d5:2101] (unknown [IPv6:2601:5cc:4480:1036:9488:4058:41d5:2101]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4jSy7l6XT6zxcN; Mon, 16 Nov 2026 19:08:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <15663fe6-a938-489a-9c9d-c9514c8b6781@FreeBSD.org> Date: Mon, 16 Nov 2026 14:08:35 -0500 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 3a1f5a28f007 - main - proc.h: Order thread_lock*() functions more logically Content-Language: en-US To: Olivier Certner , Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <6af88c7a.1655d.45212520@gitrepo.freebsd.org> <2634373.0dHE6SNnxz@ravel> From: John Baldwin In-Reply-To: <2634373.0dHE6SNnxz@ravel> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/16/26 03:14, Olivier Certner wrote: >> The functions were ordered alphabetically, as it should be. > > No, they do not need to. In some places they are, mostly because of history or because nobody bothered to classify them. It is generally much more useful to group them by usage/category. Typically, functions that must be paired should be adjacent. Hmm, my understanding of style(9) from bde matches kib@ which is to sort alphabetically. That said, in practice I tend to do that within groups, that is if there is a group of related functions, I sort them alphabetically, but may use separate groups instead of one giant group if there are comments for the groups. -- John Baldwin