git: 8a7328248622 - main - ixgbe: Classify missed packets only as input drops
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 14 Nov 2026 13:57:48 UTC
The branch main has been updated by gallatin:
URL: https://cgit.FreeBSD.org/src/commit/?id=8a73282486223f549724bb93622a50d843ccb55b
commit 8a73282486223f549724bb93622a50d843ccb55b
Author: Andrew Gallatin <gallatin@FreeBSD.org>
AuthorDate: 2026-11-14 13:52:15 +0000
Commit: Andrew Gallatin <gallatin@FreeBSD.org>
CommitDate: 2026-11-14 13:54:58 +0000
ixgbe: Classify missed packets only as input drops
Missed packets should be counted as drops, not as both drops
and errors. Errors should be reserved for things like link level
crc errors.
Reviewed by: kbowling
Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D61523
---
sys/dev/ixgbe/if_ix.c | 3 +--
sys/dev/ixgbe/ixgbe.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c
index 35bcebf985fc..5812e1950b13 100644
--- a/sys/dev/ixgbe/if_ix.c
+++ b/sys/dev/ixgbe/if_ix.c
@@ -2294,7 +2294,6 @@ ixgbe_update_stats_counters(struct ixgbe_softc *sc)
* Aggregate following types of errors as RX errors:
* - CRC error count,
* - illegal byte error count,
- * - missed packets count,
* - length error count,
* - undersized packets count,
* - fragmented packets count,
@@ -2302,7 +2301,7 @@ ixgbe_update_stats_counters(struct ixgbe_softc *sc)
* - jabber count.
*/
IXGBE_SET_IERRORS(sc, stats->crcerrs + stats->illerrc +
- stats->mpctotal + stats->rlec + stats->ruc + stats->rfc +
+ stats->rlec + stats->ruc + stats->rfc +
stats->roc + stats->rjc);
} /* ixgbe_update_stats_counters */
diff --git a/sys/dev/ixgbe/ixgbe.h b/sys/dev/ixgbe/ixgbe.h
index 41beaeaec7d7..2b32aebc2cd3 100644
--- a/sys/dev/ixgbe/ixgbe.h
+++ b/sys/dev/ixgbe/ixgbe.h
@@ -638,7 +638,6 @@ struct ixgbe_debug_dump_cmd {
"\nSum of the following RX errors counters:\n" \
" * CRC errors,\n" \
" * illegal byte error count,\n" \
- " * missed packet count,\n" \
" * length error count,\n" \
" * undersized packets count,\n" \
" * fragmented packets count,\n" \