From nobody Sat Nov 14 13:57:48 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jRbL51Cscz7160p for ; Sat, 14 Nov 2026 13:57:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jRbL50jsTz4FlP for ; Sat, 14 Nov 2026 13:57:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794664669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lni7KoHhnOwxkpuggUnbbz7MITcwaMa0bP0cKnwKhzQ=; b=vL1GBZTYzW7HjbfQidywD7N9Nsv8l384uEKI6gek/ReGEaVTXeyS/9s/cELWcVgV1zOlIt nAO+WfK57wYvmBxRAjJZf4V+h2lVVy5U7PKv52eEKiG47XeavDMZxyltf3yGRDh6IFbxs1 eAVEDwfDgIUN3Yal8/qf+MeONqCckjMN2JrLTbhhAybXpuspVLOIJ+9+Tr4hu+bBzqTX94 ciTnQUBzDZNhoRzwT8UBGuqeNGDr3Pzki7SEh309URLufy8udszkxZtjaC6r6MvC4LDZz4 xyGMwig3XCLBiSpJAw0K01CuLqmj1PAUro7TEYiJcDiOruw9f2+N2ZHMSCHFkw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794664669; b=gzs1L9zDWUcyZhxW4eKIVJATiTAaz1NcqEY55xnEYNLcYSVM6RHoy7HdYeDAiKrPERjC7r cezsO3GzaoDNqUWo2UzAEbNFf+AyDwouEHStXezjYy4iTJSns5HMEm1W/Z7ALynbf6BG4r uGAZsGPU8IKF8ZW8yHUuGEzoYJ33g3cnp9vwL75NyrKVwgwA6c1GbmmqiOBh4fw24c9k7h 4PKSgFTHh1M+PM+bwQxgIVXTBKvGjW+ybfBFJBCXdR9HHf0qzv7vGdoNyOZH5/46140uDe Xn+imPyqk0x7Jbb6Ctrkl0FycQ7XmmOFoHDigD0kgEXvG4RCWWYi7WN/6VzvjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794664669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lni7KoHhnOwxkpuggUnbbz7MITcwaMa0bP0cKnwKhzQ=; b=pYr9JScgd/4av/OsSkJ9u6mSB9lPD/T2av0z6sk06PJS5TjabB7HY5e3Kd0wRc9Qe88DGd 7dQFfzO0T6vwsJ/pSsZFSL14xfkyWozWq2KSlvLSvTjB3KHKTFdhsPS/jJvQobPN5nDsfL 2HE195lwS/UqPB8vMcUKjjYZwNW0GsoLDHkCJ+Pm4XTWe75sYtUsqjDUVLqR2elYRUaxuN nulUF82YtUdunmERKOgbamp7+pZ/ZaD2OEmmhfBqdi6hZBwqNeov9hEa879irAHlcdnhTZ yLTzs3Z46IPWC9EdfP7lU25aIzqES6xMtXyZuhKhpMntiiRbednLKM3zog9IWw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jRbL46xrBzP3M for ; Sat, 14 Nov 2026 13:57:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 81af by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 14 Nov 2026 13:57:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: 8a7328248622 - main - ixgbe: Classify missed packets only as input drops List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8a73282486223f549724bb93622a50d843ccb55b Auto-Submitted: auto-generated Date: Sat, 14 Nov 2026 13:57:48 +0000 Message-Id: <6af868dc.81af.58a4e405@gitrepo.freebsd.org> The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=8a73282486223f549724bb93622a50d843ccb55b commit 8a73282486223f549724bb93622a50d843ccb55b Author: Andrew Gallatin AuthorDate: 2026-11-14 13:52:15 +0000 Commit: Andrew Gallatin CommitDate: 2026-11-14 13:54:58 +0000 ixgbe: Classify missed packets only as input drops Missed packets should be counted as drops, not as both drops and errors. Errors should be reserved for things like link level crc errors. Reviewed by: kbowling Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D61523 --- sys/dev/ixgbe/if_ix.c | 3 +-- sys/dev/ixgbe/ixgbe.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 35bcebf985fc..5812e1950b13 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -2294,7 +2294,6 @@ ixgbe_update_stats_counters(struct ixgbe_softc *sc) * Aggregate following types of errors as RX errors: * - CRC error count, * - illegal byte error count, - * - missed packets count, * - length error count, * - undersized packets count, * - fragmented packets count, @@ -2302,7 +2301,7 @@ ixgbe_update_stats_counters(struct ixgbe_softc *sc) * - jabber count. */ IXGBE_SET_IERRORS(sc, stats->crcerrs + stats->illerrc + - stats->mpctotal + stats->rlec + stats->ruc + stats->rfc + + stats->rlec + stats->ruc + stats->rfc + stats->roc + stats->rjc); } /* ixgbe_update_stats_counters */ diff --git a/sys/dev/ixgbe/ixgbe.h b/sys/dev/ixgbe/ixgbe.h index 41beaeaec7d7..2b32aebc2cd3 100644 --- a/sys/dev/ixgbe/ixgbe.h +++ b/sys/dev/ixgbe/ixgbe.h @@ -638,7 +638,6 @@ struct ixgbe_debug_dump_cmd { "\nSum of the following RX errors counters:\n" \ " * CRC errors,\n" \ " * illegal byte error count,\n" \ - " * missed packet count,\n" \ " * length error count,\n" \ " * undersized packets count,\n" \ " * fragmented packets count,\n" \