Re: git: de6328af0c8c - main - tests/sys/kern/ssl_sendfile: :eagain_vs_eof: improve failure messaging
Date: Fri, 13 Nov 2026 01:57:53 UTC
> On Nov 12, 2026, at 4:13 PM, Siva Mahadevan <siva@FreeBSD.org> wrote: … > In the future, please use the narrower ATF_REQUIRE_*EQ or > ATF_REQUIRE_*EQ_MSG macros, as they will include the expected/actual > values in the message directly in a uniform way. In this file, > ATF_REQUIRE_INTEQ_MSG would've worked well in many cases. > > I have a local WIP sweeping change patch > to change all trivial equality checks using ATF_REQUIRE to the narrower > macros, I'll post that for review sometime. Yeah, you’re right. The one thing to watch out for is double evaluation in the macros: https://github.com/freebsd/atf/issues/1 . Good catch. -Enji