From nobody Fri Nov 13 01:57:53 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jQgQB0pzpz6y44F for ; Fri, 13 Nov 2026 01:58:10 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jQgQ86J35z4rQl for ; Fri, 13 Nov 2026 01:58:08 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20260707 header.b=DZAISH+o; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::434 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-8a06cc097c7so548909b3a.0 for ; Thu, 12 Nov 2026 17:58:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794535087; x=1795139887; darn=freebsd.org; h=references:to:cc:in-reply-to:date:subject:mime-version:content-type :message-id:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HiLZg71JVyk4YhGFekc1I/Nd21QsU93y0WRy0nGG3cU=; b=DZAISH+oN1rWo7UMVeLlaX6KffEpS5Fa8tOV3EQphg6Qq/lA8hyDFozm6kM0qtqJQF ShyOBlbliiOeAnTcap3J+VUmLU/TRUdueZSwdwGv9fDJu9Vs1oU6yqllLwGNUDYAxt02 T9TUqJrBuItkueUeBl5RQpLdhpkDytD67pnfveCy5XeVuf2jJPkERPt8Li7Uxvgus9OU amQEaqjNuUZSC/mCAl2781CvmZYv2+wNbVGws18+iB11BLpAEfyDQLxkTR/lRrAEfArW /eM0LEd8s1oVNqaBE9QGpOAkzqMeaNqkENFZpN1uKDJ5Z4NuRNSZJNPcW05Aln6boyps z8dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794535087; x=1795139887; h=references:to:cc:in-reply-to:date:subject:mime-version:content-type :message-id:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HiLZg71JVyk4YhGFekc1I/Nd21QsU93y0WRy0nGG3cU=; b=IrKKMMnNPkVAxHeRpAROdX6f04uwYDzPPZhJMbjxheFeFpEpq2EYKSOuRVnl+DE0xC a7GG4jTptKrj8Ml4x0qxrYg0aMx2Oa2KyY1yRQfLrm0U6Sveh7sHQMuLkn+RzH9n8klJ kB9FWPfsi4NYF8OnepMt4sDu0JM9RascLQAVFyHRXt9gK5ohoBkuZ73RdLLafDBYhWLm KgWDtuMsDDVrlJk+mv/lCfNPXK2ZEpAb5WnWwTFtDhbA8R/PjKw7OTTck+30H0EEMBS9 65fMVuQ5/WuHX18xDSEgNum+JT2mJFJprMVZoMQU3rbhgH+Ig6ki84porDIGcvkMR+Xk 6Aqw== X-Forwarded-Encrypted: i=1; AL+hErGJL6zpQg9wkPA1tAAFf1e2j9SNJiart/eDMdEAa1PidGlUp+5SKyGeTNvj1mDuygLwJvifeNraGPm28O56uK9HOLFY@freebsd.org X-Gm-Message-State: APuU4Z9lpaMHA0gZvwEJHqrFR+ZZTIqoz0zPdEBYgv8fEzje4xDtC4Rh QY1p/bNjpcpETzMB6XQkPhj61IEsf7m4EbzmlBOh1FWgc1w5bk0x8CSB X-Gm-Gg: AYBFou3uysUpC0+4TRNb6yFUGP0AsgY072mUx0EQXbfapTNNNf6QwEh32hR8WtXJW/u 9Kt6k3/yRuQLpvw+SXbEVRBqcq3Pde9j5CP4h2mWSrpAThgW4rLiJytnUGBq36QAEbpYXCoB28K zOixuswnOAtuxlzYBNwNmUVkb1v3TJ5xsyMgy1Ox9KG+rHAZ/U1+OuiU/lxuAJYX+gGkXHRYUUg tPLehyTOBzin1/t5cpkXJ5XV4qo6g2xLV6vJDCo2EVgUVJxIlh/fkA191Mlw7qxvEO0fUBvc33p jqhuEgblrsMZBH09GPrvR4EkEBh0U5xQaYilIIdkPuEUSM73VbxICCNNhBIQqqtX53LBHimSBBX nWkycd1Cs4owSRnw8+fyaFyUOGpEVaKTV/SvSb/7AXOrpaZJAaltFSEx8io7A2xerzFGJ8qR2WQ Rp+aAZrwQ3MpsRK9BegFd0brL9gkTvJTXrqoCwcP2fVDOaAiLmY6pg1YlQn5FaJq4p0SftVQ2A2 nA34tqojvqTFoqj88cieBJHxjgNSO1ESW+Ixgo1kA8r2eiJKUXhG8OdeiyM+hHpYcV7ZwD+4WwO jm1/0s0vCOQDVgx3jcLo758hTMeY4hr8+nZ3VDdF75SjE2WeLJ0= X-Received: by 2002:a05:6a00:995:b0:89d:faf6:c69d with SMTP id d2e1a72fcca58-8beb8ccd264mr1164875b3a.58.1794535086469; Thu, 12 Nov 2026 17:58:06 -0800 (PST) Received: from smtpclient.apple ([187.15.153.20]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8bed12a8682sm313734b3a.10.2026.11.12.17.58.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Nov 2026 17:58:05 -0800 (PST) From: "Enji Cooper (yaneurabeya)" Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_C2F52F6C-3027-40BF-8D61-4505F01D09C5"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.4\)) Subject: Re: git: de6328af0c8c - main - tests/sys/kern/ssl_sendfile: :eagain_vs_eof: improve failure messaging Date: Thu, 12 Nov 2026 17:57:53 -0800 In-Reply-To: Cc: Enji Cooper , "" , "" , "" To: Siva Mahadevan References: <6af652f6.10773.23c7dab7@gitrepo.freebsd.org> X-Mailer: Apple Mail (2.3864.700.51.1.4) X-Rspamd-Queue-Id: 4jQgQ86J35z4rQl X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.60 / 15.00]; SIGNED_PGP(-2.00)[]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MIME_GOOD(-0.20)[multipart/signed,multipart/alternative,text/plain]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20260707]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56:c]; RCVD_TLS_LAST(0.00)[]; TO_DN_ALL(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~,4:~]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::434:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; HAS_ATTACHMENT(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] --Apple-Mail=_C2F52F6C-3027-40BF-8D61-4505F01D09C5 Content-Type: multipart/alternative; boundary="Apple-Mail=_14A33A39-4B4E-4980-998F-44C8D131E43A" --Apple-Mail=_14A33A39-4B4E-4980-998F-44C8D131E43A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Nov 12, 2026, at 4:13=E2=80=AFPM, Siva Mahadevan = wrote: =E2=80=A6 > In the future, please use the narrower ATF_REQUIRE_*EQ or > ATF_REQUIRE_*EQ_MSG macros, as they will include the expected/actual > values in the message directly in a uniform way. In this file, > ATF_REQUIRE_INTEQ_MSG would've worked well in many cases. >=20 > I have a local WIP sweeping change patch > to change all trivial equality checks using ATF_REQUIRE to the = narrower > macros, I'll post that for review sometime. Yeah, you=E2=80=99re right. The one thing to watch out for is double = evaluation in the macros: https://github.com/freebsd/atf/issues/1 . Good = catch. -Enji= --Apple-Mail=_14A33A39-4B4E-4980-998F-44C8D131E43A Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On= Nov 12, 2026, at 4:13=E2=80=AFPM, Siva Mahadevan = <siva@FreeBSD.org> = wrote:

=E2=80=A6

In the future, please use the narrower = ATF_REQUIRE_*EQ or
ATF_REQUIRE_*EQ_MSG macros, as they will = include the expected/actual
values in the message directly in a uniform = way. In this file,
ATF_REQUIRE_INTEQ_MSG would've worked well = in many cases.

I have a local WIP sweeping change = patch
to change all trivial equality checks using = ATF_REQUIRE to the narrower
macros, I'll post that for review = sometime.

Yeah, = you=E2=80=99re right. The one thing to watch out for is double = evaluation in the macros: https://github.com/freebs= d/atf/issues/1 . Good catch.
-Enji
= --Apple-Mail=_14A33A39-4B4E-4980-998F-44C8D131E43A-- --Apple-Mail=_C2F52F6C-3027-40BF-8D61-4505F01D09C5 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmr2bqEACgkQGpE5DjPs NJhezA//fCqxeOmPuCsdE5dYkCpzG7zc9HVfwOGuYH0VCPqmDt2kFnRhn8/JXq28 3ibzGLkzPSd9MVxnfuF+SxUffIjw+bRYNwlRpuh9zMcUDuYYNZmF1lvNNtBhEarY QPMv10H604sAxNCt8EJNvptUcc19qgem5XeknuoSvu1IUGZGRxkyeNbnkOF3oQdC nH3lpe3gNViSECwTjDLjFk7dX1aqpbv5FXM3GGt3XKpMaTW6mNC9uvZC2NawzbT/ 6NK43TqNa9/yooUKDq/OxCSJC36Cevd+uo5QT579hVWq5ycBPkp8aane43XY/iZA SWflzLgKNMNGqncXlmbn0SLBmx6/QHRylMnNk7TeN0negjOKEmiH6v9pZv2gyuLi oJECcqpVcBimBobtVdaz4yI/0aAtpGl/s+GCPreH+ulKU+nKKlny2AhQm8fRlREP iXbU3ZJ8meUdhWAy8fZP16P/Ie3LjV6FF2WuuE+1m7kj7Qgs1+5+JmVlN+XTbIUI 8aA4q7JyTng4X71FWYqPdCfBCesa8kS9zbVnqKogCWa3SNZkAiWLcYlKsZ19zpeA k4AN1Bd5hN6sUVOJU7SZei8mzIO+IwsLM/keUNo5wJFzcFl4ytfo+dxolH/MS1j/ NUJmBlNvMAeiqI6Jp+6KBpl20CzkgK4rgTE9jL/tNtTUwQJH34g= =hKtL -----END PGP SIGNATURE----- --Apple-Mail=_C2F52F6C-3027-40BF-8D61-4505F01D09C5--