Re: git: 431cc94c0395 - main - user_connectat: correctly pass fd through
- In reply to: Brooks Davis : "git: 431cc94c0395 - main - user_connectat: correctly pass fd through"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 11 Nov 2026 15:05:46 UTC
On Wed, Nov 11, 2026 at 02:57:46PM +0000, Brooks Davis wrote:
> The branch main has been updated by brooks:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=431cc94c0395205f7859d5f65289f9f2ebbe8162
>
> commit 431cc94c0395205f7859d5f65289f9f2ebbe8162
> Author: Brooks Davis <brooks@FreeBSD.org>
> AuthorDate: 2026-11-11 14:41:40 +0000
> Commit: Brooks Davis <brooks@FreeBSD.org>
> CommitDate: 2026-11-11 14:57:13 +0000
>
> user_connectat: correctly pass fd through
>
> In the original adaptation of connect/connectat to use user_connectat in
> CheriBSD, I failed to pass the fd through in the connectat case and
> always passed AT_FDCWD. This did trigger failures in the unix_connectat
> test which I somehow missed in prior test runs.
>
> Reported by: llm-postcr
Oops, this should include:
Fixes: 65e94d4621c8 ("uipc_syscalls.c: add kern_ and user_ implementations")
Somewhat surprisingly, this is a 10+ year old bug from CheriBSD, I guess
connectat doesn't get used much in the base or we'd have noticed it
organically.
-- Brooks