From nobody Wed Nov 11 15:05:46 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jPmzv3TJgz70KVN; Wed, 11 Nov 2026 15:05:47 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jPmzv30lxz4QmL; Wed, 11 Nov 2026 15:05:47 +0000 (UTC) (envelope-from brooks@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794409547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mSLieWx45ktg572ACHSltgDQ4P658DC5dBydChcNMBg=; b=B6n/FviSw5b+kI+8eJ/k5PdmSeo6p+2EzMrbL7tBaP8mw9qHn9PbophDSow1OOCNSmyHYU fd9KXnG9nmvXvDtbnvQB2DtoaXc7N0jmPcloovwCGrd5po8HIPWOcbDe6MOka014rxt2v2 ki+UoIxi3+69C6mnkff12OjCl+CgTQ318TB8AXPA+Ip1ZNo00yjMWufyvudpDPHQnCeEjo w4nf22hEkqlv0Uug1uYD8dIRb4A8BukBUf65EioaqxiGs/82rLzVCUUOAQNq7yfnwKxp69 d2ChO1UOGhC45FWBCF7m216Qc+AWEyFxkj0w91hw1vvj9j6cduyI4Cgz0CEszA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794409547; b=MbmV0Og1eL4kRIZbh9a2T5wSFtAz1bwcL1oC1785fEDMFkwEBLQANmgB7tihdqkmmqhA1I jc2+kToach+vjk8EVQE7c+TC5YrJ8/pErtPW0a5RGM/2aSSgWdOGFr/c9vj9e0wEqHaZpN dj92uJh2fhW7D8wbf1YDYRFUgyqyIjKesnMYNkcwd9uaBhulIERRcGKwhy2QW78y6FRcWX bXuOtQOy/rigFefeupJzzk190cTaY1ch2mL9OqCb5xi7rmvoj6Z/LCCbDaTpZDAg2dX+Iw wBW88/SS/YzwV5JB9qUzXUik1JdjgyAr9wVtJcXTBD7MXiUVNUqTmzlN2n8BAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794409547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mSLieWx45ktg572ACHSltgDQ4P658DC5dBydChcNMBg=; b=Sck7x1ziTHfpbWvUBJH1BXTFurdqVpQ639u0eCFzPyUfqb0SCBQFtCkpQef3d7f9gbtpgP fmJd6nXm66/yiw7ZuoMuJccAJK7QN60Bw4yO8vazSgcc0ICTytoZsgBYMGDVdmHFiYjyIC WpxWBe233b67FF6fYyI1Fy6PAtZnIT+EbFZ73fTp+kvd0ti77FS2Ljtepi097pakWxmm3Y Dj/BBWb/Qx8icuoUkK0rsjCagaWOVQJp3IDGEYLvH1sWroh6FoZkQ2PIPcRFRogBzzJX+x vw9kQFSE4H5Ccfr5khjz4M5R1XhsUCVuwhfjT+naLRbdlrTjSiAAwaa4b/KXDA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: brooks/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4jPmzv2GW1z1Rq4; Wed, 11 Nov 2026 15:05:47 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id AB4E83C01A0; Wed, 11 Nov 2026 15:05:46 +0000 (UTC) Date: Wed, 11 Nov 2026 15:05:46 +0000 From: Brooks Davis To: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 431cc94c0395 - main - user_connectat: correctly pass fd through Message-ID: References: <6af4826a.1084c.785edf9e@gitrepo.freebsd.org> List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6af4826a.1084c.785edf9e@gitrepo.freebsd.org> On Wed, Nov 11, 2026 at 02:57:46PM +0000, Brooks Davis wrote: > The branch main has been updated by brooks: > > URL: https://cgit.FreeBSD.org/src/commit/?id=431cc94c0395205f7859d5f65289f9f2ebbe8162 > > commit 431cc94c0395205f7859d5f65289f9f2ebbe8162 > Author: Brooks Davis > AuthorDate: 2026-11-11 14:41:40 +0000 > Commit: Brooks Davis > CommitDate: 2026-11-11 14:57:13 +0000 > > user_connectat: correctly pass fd through > > In the original adaptation of connect/connectat to use user_connectat in > CheriBSD, I failed to pass the fd through in the connectat case and > always passed AT_FDCWD. This did trigger failures in the unix_connectat > test which I somehow missed in prior test runs. > > Reported by: llm-postcr Oops, this should include: Fixes: 65e94d4621c8 ("uipc_syscalls.c: add kern_ and user_ implementations") Somewhat surprisingly, this is a 10+ year old bug from CheriBSD, I guess connectat doesn't get used much in the base or we'd have noticed it organically. -- Brooks