git: 7ac5569c5d9e - main - vn_open_cred(9): fix ni_startdir leak
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 10 Nov 2026 19:54:22 UTC
The branch main has been updated by kib:
URL: https://cgit.FreeBSD.org/src/commit/?id=7ac5569c5d9e601201c811786e6d0026f8aa3c1b
commit 7ac5569c5d9e601201c811786e6d0026f8aa3c1b
Author: Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2026-11-10 01:03:47 +0000
Commit: Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2026-11-10 19:53:27 +0000
vn_open_cred(9): fix ni_startdir leak
vn_open_cred() returns EINVAL before calling namei() for
O_CREAT|O_EXCL|O_DIRECTORY and for O_CREAT|O_EMPTY_PATH.
That leaks an NDINIT_ATVP() start directory.
Reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D61366
---
sys/kern/vfs_vnops.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c
index 0bb8bfffec85..78c13bb6e033 100644
--- a/sys/kern/vfs_vnops.c
+++ b/sys/kern/vfs_vnops.c
@@ -301,9 +301,11 @@ restart:
fmode = *flagp;
if ((fmode & (O_CREAT | O_EXCL | O_DIRECTORY)) == (O_CREAT |
O_EXCL | O_DIRECTORY) ||
- (fmode & (O_CREAT | O_EMPTY_PATH)) == (O_CREAT | O_EMPTY_PATH))
+ (fmode & (O_CREAT | O_EMPTY_PATH)) == (O_CREAT | O_EMPTY_PATH)) {
+ if (ndp->ni_startdir != NULL)
+ vrele(ndp->ni_startdir);
return (EINVAL);
- else if ((fmode & (O_CREAT | O_DIRECTORY)) == O_CREAT) {
+ } else if ((fmode & (O_CREAT | O_DIRECTORY)) == O_CREAT) {
ndp->ni_cnd.cn_nameiop = CREATE;
ndp->ni_cnd.cn_flags = open2nameif(fmode, vn_open_flags,
ndp->ni_cnd.cn_flags);