From nobody Tue Nov 10 19:54:22 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jPHRL4WfMz6vLqr for ; Tue, 10 Nov 2026 19:54:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jPHRL2Nvpz3NQs for ; Tue, 10 Nov 2026 19:54:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794340462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=49S+bWtsDvSZd2jBjVsksFAO9LV0QmdTcnhJsqOZ7Bs=; b=YdmZMfCBBHD7LeWC4crijzsJfgU+lDXfz6t/PqwejHMu9NlRdTT2fSKAJMGQOxZVY85ifZ OTfWh0y9g8ExCFaASBteG08Gx+jmmngA7KUdq5nRI+PZHMpTrQPWK4qVoDAKhOgzUZSkHA P56kuhwRmu0TDW9tTgvLVkEMYWa+GpanrLyM7bGbOOAnjxpRonOCTGqRUkeWyj+PAr6Xzt J/jxCoVcVqGo8W4XTKmXyuRitgFak9cH++5iKHRhfVKG8ycRKQej5m6ehMJ1OZm5q6NpPP 6moydRjPpom/h+uKRgkjbOS2zTMHYRtxo1xEd1UHI05/FbEIPApcQTnl08DuXQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1794340462; b=yPONGheXARtUem20V6zMsDSEapEAiCSz3hMTNAa0yhNaVUEmN3B4G/M5bJ3QEn9+Aq6MWh SzEd+1co+OH+FFqCCrbG8dVoBkyhFXNqmYqwmxXPOcK0gclnlsNgOJnF4fKMV/AW4nnHrJ 0/rLo9fhAitttW2fgbdDpkQSUQ2yHDrK3mv2Du0zfMPlvw1ckS3UKKreTVnOz5evoD4jV2 P9opZROYxnjYzKB6eZuTrTM/V2/jwyt/71/J3/CU/WfWIoMoli0IfNnV7HehFf0c2M2Ekh R7jP1ZLTptQvr3dzMzEskp96ctoRw6r7/PYnSHj0zTU31575pz2MEpMEH1st7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1794340462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=49S+bWtsDvSZd2jBjVsksFAO9LV0QmdTcnhJsqOZ7Bs=; b=BJT7pPAg1y59QjDbQxKGrbetrBQv022jzkZm4mIRPRSnRVJYLCIJP1ZLQREf0mXANlFcqM Guv8TMVnrkYOhehy3cblCekkET6GygdFbmgJoTWRHqi4Owu6WCMdw3HBwNTzDPgVTxKChv GY/VzdLmmZYh0JQADOucDcO36qTltU1bcYG8yyQOAR+rSshFFqHxCxwmHOf2MZT1OLVoXu sAa5usYWPw9GkeJNMUqMiPt6jZerRUF4ZH+MTz1oJ3/HcY7Nmsvq9NqMlTCQ3kBI8Icoog D8gqP2xiESbDL4CTg++GqQcqBjc+LG7dIEF5lZlx2LQIU3JIX/goV+sCq9KvbQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jPHRL1m24zjHB for ; Tue, 10 Nov 2026 19:54:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 29f7 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Nov 2026 19:54:22 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 7ac5569c5d9e - main - vn_open_cred(9): fix ni_startdir leak List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7ac5569c5d9e601201c811786e6d0026f8aa3c1b Auto-Submitted: auto-generated Date: Tue, 10 Nov 2026 19:54:22 +0000 Message-Id: <6af3766e.29f7.70bff9d4@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=7ac5569c5d9e601201c811786e6d0026f8aa3c1b commit 7ac5569c5d9e601201c811786e6d0026f8aa3c1b Author: Konstantin Belousov AuthorDate: 2026-11-10 01:03:47 +0000 Commit: Konstantin Belousov CommitDate: 2026-11-10 19:53:27 +0000 vn_open_cred(9): fix ni_startdir leak vn_open_cred() returns EINVAL before calling namei() for O_CREAT|O_EXCL|O_DIRECTORY and for O_CREAT|O_EMPTY_PATH. That leaks an NDINIT_ATVP() start directory. Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D61366 --- sys/kern/vfs_vnops.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c index 0bb8bfffec85..78c13bb6e033 100644 --- a/sys/kern/vfs_vnops.c +++ b/sys/kern/vfs_vnops.c @@ -301,9 +301,11 @@ restart: fmode = *flagp; if ((fmode & (O_CREAT | O_EXCL | O_DIRECTORY)) == (O_CREAT | O_EXCL | O_DIRECTORY) || - (fmode & (O_CREAT | O_EMPTY_PATH)) == (O_CREAT | O_EMPTY_PATH)) + (fmode & (O_CREAT | O_EMPTY_PATH)) == (O_CREAT | O_EMPTY_PATH)) { + if (ndp->ni_startdir != NULL) + vrele(ndp->ni_startdir); return (EINVAL); - else if ((fmode & (O_CREAT | O_DIRECTORY)) == O_CREAT) { + } else if ((fmode & (O_CREAT | O_DIRECTORY)) == O_CREAT) { ndp->ni_cnd.cn_nameiop = CREATE; ndp->ni_cnd.cn_flags = open2nameif(fmode, vn_open_flags, ndp->ni_cnd.cn_flags);