git: 2c6b01416f80 - main - ixgbe: Guard E610 Link Default Override access
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 04 Nov 2026 16:58:44 UTC
The branch main has been updated by kbowling:
URL: https://cgit.FreeBSD.org/src/commit/?id=2c6b01416f80462b393bbe70a38cea017325dea8
commit 2c6b01416f80462b393bbe70a38cea017325dea8
Author: Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2026-11-04 16:55:44 +0000
Commit: Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2026-11-04 16:58:26 +0000
ixgbe: Guard E610 Link Default Override access
Reading Link Default Override uses the E610 Admin Command Interface,
whose mutex is initialized only on E610. Calling it on other adapters
can hang attach, as observed on X520.
Skip the read on non-E610 devices, leaving the cached policy invalid so
that the existing link-state guard also skips force-link commands.
Reviewed by: kgalazka
Fixes: 7868958f5c79 ("ix(4): Support Total Port Shutdown on E610")
MFC after: 1 week
Sponsored by: BBOX.io
Differential Revision: https://reviews.freebsd.org/D61144
---
sys/dev/ixgbe/if_ix.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c
index bbce4012ca53..b429fb3992fb 100644
--- a/sys/dev/ixgbe/if_ix.c
+++ b/sys/dev/ixgbe/if_ix.c
@@ -377,6 +377,10 @@ ixgbe_cache_ldo_policy(struct ixgbe_softc *sc)
sc->ldo_valid = false;
sc->ldo_port_disabled = false;
+ /* Link Default Override uses the E610-only Admin Command Interface. */
+ if (hw->mac.type != ixgbe_mac_E610)
+ return;
+
error = ixgbe_get_link_default_override(hw, &ldo);
if (error) {
device_printf(sc->dev,