From nobody Wed Nov 04 16:58:44 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jKWqY5f3Hz6yVPX for ; Wed, 04 Nov 2026 16:58:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jKWqY4dl7z4rs3 for ; Wed, 04 Nov 2026 16:58:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793811529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ILmtuKUtOq/awXVz3BrkijiQAqUVD1kZ5OL4R1fdsfk=; b=b/tAsLW8mt3lW6lDNikxaUvvVFTrlgTR1bh0cXCrLaRXw2b9c2g+Q3lQnXPDhTcZGMKlQ3 MxVUdbkDdUPyFNejmwxWKT3su/P8I2ZfP6affZexzp3eknfu1+U0GUL1s/aEiRYpySGPft 4Klg9Sl59Il/wwhPXwJQNUEpg7mVnDPz5rJPwj79LaUTie8DeQqdLgI+duxSccHvS3olBo HnkPdSAopCHEETmUBVj0Gb2x9f9nNuWttPEDu+QhOWf4vXj98bLRnjoXuCHBgMrb/k5RNw //fRs1WYZgFZgdnjFmVH6SR/ASRm56IndT66G/UMANIF3FBlzvhiNhSyY0AKYQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793811529; b=hVMH2rXYGxiyLHQcJrqJ0lnYb5Nfb3wT0JdZ6LC6Cjqc9P9sMNxvAbu+WVMy9CvD1bNrMZ vL7e7diVL38BISz4atYlzuNnwfB8R1tX+6iyfn4leGo3MrGpW/YmrDbG9pPUXCu43UObyZ SbsSuqxuLm7O+aC9ENZYxWRufsVphdPG/DJxIV2R/osU9qs3J1lY0o0Mt+yNJCRcyagacR e4Wa99IPICs6uBTaDZIOzOxCb+xqJbkdJjxGyGAz5ery9Jog+GmzhAJAnCVaROnzOy6pmh mCwLRTfA7Q65V6vPQXm1yG7ZzE3205EtqgCsRlh3ZO/YHXS0lWseu9+HetyZ6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793811529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ILmtuKUtOq/awXVz3BrkijiQAqUVD1kZ5OL4R1fdsfk=; b=CjUwTt1l6ro+IXCsDCuavyyli62tgxLYdFPugijt7wvrFOeeOOK1k9Qw4RvnuSyeOgPYIo j4fouEj4cvFOAd38yjML0d6mxMbUlOxyrpQhAUIADyzNfjOLWYN8u2uO7klHtmKV8VsKS+ 09zatnMWyQiYZ0LYoC8ZoAyeQ6UOSYamahbwSIlcm9/9qwZ8c/wD/cb9niypWxpRVtd62o F1JztmjqFekulK8HVqjmYbD1QS+jDhSu+Mk/ZUYVLMuogtBRa7l71QEYlOgJlcYAMxQjbP FVC+wShgm9psdI8xE0CRzfZTmdj9ahEaftA7bKRAzbRbni9+8r+FYwDH1eqWIQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jKWqY4Bbhz19wG for ; Wed, 04 Nov 2026 16:58:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 20d6a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Nov 2026 16:58:44 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 2c6b01416f80 - main - ixgbe: Guard E610 Link Default Override access List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2c6b01416f80462b393bbe70a38cea017325dea8 Auto-Submitted: auto-generated Date: Wed, 04 Nov 2026 16:58:44 +0000 Message-Id: <6aeb6444.20d6a.13cbf7f6@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=2c6b01416f80462b393bbe70a38cea017325dea8 commit 2c6b01416f80462b393bbe70a38cea017325dea8 Author: Kevin Bowling AuthorDate: 2026-11-04 16:55:44 +0000 Commit: Kevin Bowling CommitDate: 2026-11-04 16:58:26 +0000 ixgbe: Guard E610 Link Default Override access Reading Link Default Override uses the E610 Admin Command Interface, whose mutex is initialized only on E610. Calling it on other adapters can hang attach, as observed on X520. Skip the read on non-E610 devices, leaving the cached policy invalid so that the existing link-state guard also skips force-link commands. Reviewed by: kgalazka Fixes: 7868958f5c79 ("ix(4): Support Total Port Shutdown on E610") MFC after: 1 week Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D61144 --- sys/dev/ixgbe/if_ix.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index bbce4012ca53..b429fb3992fb 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -377,6 +377,10 @@ ixgbe_cache_ldo_policy(struct ixgbe_softc *sc) sc->ldo_valid = false; sc->ldo_port_disabled = false; + /* Link Default Override uses the E610-only Admin Command Interface. */ + if (hw->mac.type != ixgbe_mac_E610) + return; + error = ixgbe_get_link_default_override(hw, &ldo); if (error) { device_printf(sc->dev,