Re: git: 70c9d0479900 - main - bsdinstall: Ensure logging retained when BSDINSTALL_LOG is not changed by preamble

In reply to: Devin Teske : "git: 70c9d0479900 - main - bsdinstall: Ensure logging retained when BSDINSTALL_LOG is not changed by preamble"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Harry Schmalzbauer <freebsd_at_omnilan.de>
Date: Sun, 01 Nov 2026 12:05:06 UTC

On 2026-08-22 07:32, Devin Teske wrote:
> The branch main has been updated by dteske:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=70c9d047990017394a872474c81fcdd66b502168
>
> commit 70c9d047990017394a872474c81fcdd66b502168
> Author:     Stephen J. Kiernan <stevek@FreeBSD.org>
> AuthorDate: 2026-08-22 05:29:37 +0000
> Commit:     Devin Teske <dteske@FreeBSD.org>
> CommitDate: 2026-08-22 05:29:37 +0000
>
>      bsdinstall: Ensure logging retained when BSDINSTALL_LOG is not changed by preamble
>      
>      Before the preamble script is sourced, initialize BSDINSTALL_LOG with the
>      file in $debugFile, if it is not already set.
>      
>      Without this change, the bsdinstall script would assume the preamble set
>      BSDINSTALL_LOG to empty and the comparison with $debugFile will fail,
>      causing the log to be re-initialized to /dev/null.
>      
>      Reviewed by:    dteske
>      MFC after:      1 week
>      Differential Revision:  https://reviews.freebsd.org/D25343


Hello,

do you still plan to MFC this?

Thanks,

-harry