From nobody Sun Nov 01 12:05:06 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jHYS50GcYz6y9ML for ; Sun, 01 Nov 2026 12:05:09 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2001:41d0:700:4a43:a25:de0:0:13]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jHYS42b3lz4Gyg; Sun, 01 Nov 2026 12:05:08 +0000 (UTC) (envelope-from freebsd@omnilan.de) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of freebsd@omnilan.de designates 2001:41d0:700:4a43:a25:de0:0:13 as permitted sender) smtp.mailfrom=freebsd@omnilan.de Received: from mh0.gentlemail.de (mh0.gentlemail.de [135.125.173.218]) by mx0.gentlemail.de (8.18.1/8.18.1) with ESMTP id 6A1C57gx043272; Sun, 1 Nov 2026 12:05:07 GMT (envelope-from freebsd@omnilan.de) Received: from [172.21.35.3] (s1.omnilan.de [217.91.127.234]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id 495E11AD24; Sun, 01 Nov 2026 12:05:07 +0000 (UTC) Message-ID: <93c8fc3a-a48e-475b-a2c8-829acc3148fa@omnilan.de> Date: Sun, 1 Nov 2026 13:05:06 +0100 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 70c9d0479900 - main - bsdinstall: Ensure logging retained when BSDINSTALL_LOG is not changed by preamble To: Devin Teske , dev-commits-src-all@FreeBSD.org Cc: "Stephen J. Kiernan" References: <6a893455.1d680.62f622a2@gitrepo.freebsd.org> Content-Language: en-US, de-DE From: Harry Schmalzbauer Organization: OmniLAN In-Reply-To: <6a893455.1d680.62f622a2@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4jHYS42b3lz4Gyg X-Spamd-Bar: / X-Spamd-Result: default: False [-0.30 / 15.00]; R_SPF_ALLOW(-0.20)[+mx:c]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; DMARC_NA(0.00)[omnilan.de]; ARC_NA(0.00)[]; HAS_ORG_HEADER(0.00)[]; ASN(0.00)[asn:16276, ipnet:2001:41d0::/32, country:FR]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[217.91.127.234:received]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_THREE(0.00)[3] On 2026-08-22 07:32, Devin Teske wrote: > The branch main has been updated by dteske: > > URL: https://cgit.FreeBSD.org/src/commit/?id=70c9d047990017394a872474c81fcdd66b502168 > > commit 70c9d047990017394a872474c81fcdd66b502168 > Author: Stephen J. Kiernan > AuthorDate: 2026-08-22 05:29:37 +0000 > Commit: Devin Teske > CommitDate: 2026-08-22 05:29:37 +0000 > > bsdinstall: Ensure logging retained when BSDINSTALL_LOG is not changed by preamble > > Before the preamble script is sourced, initialize BSDINSTALL_LOG with the > file in $debugFile, if it is not already set. > > Without this change, the bsdinstall script would assume the preamble set > BSDINSTALL_LOG to empty and the comparison with $debugFile will fail, > causing the log to be re-initialized to /dev/null. > > Reviewed by: dteske > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D25343 Hello, do you still plan to MFC this? Thanks, -harry