Re: git: bd15d6ef126e - main - libarchive: Force GNU iconv compatibility on FreeBSD

From: Dag-Erling_Smørgrav <des_at_FreeBSD.org>
Date: Thu, 28 May 2026 08:20:15 UTC
Antoine Brodin <antoine@freebsd.org> writes:
> Dag-Erling Smørgrav <des@freebsd.org> writes:
> > commit bd15d6ef126ee4c0eac931117f6bbbf6f9a3fc72
> > Author:     Mark Johnston <markj@FreeBSD.org>
> > AuthorDate: 2026-05-20 16:39:40 +0000
> > Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
> > CommitDate: 2026-05-27 13:10:57 +0000
> >
> >     libarchive: Force GNU iconv compatibility on FreeBSD
> >
> >     When libarchive is compiled with FreeBSD's native iconv instead of
> >     libiconv, as happens with libarchive in the base system, we need to
> >     configure iconv(3) to handle invalid sequences by returning -1, as
> >     iconv_strncat_in_locale() assumes GNU iconv semantics.
> >
> >     This corresponds to upstream PR 3056.
> >
> >     PR:             294577
> >     MFC after:      1 week
> Could this change break some ports?

Your logs show that LC_COLLATE is set to C.  It should be set to
C.UTF-8, or simply not set at all since LANG is already C.UTF-8.

DES
-- 
Dag-Erling Smørgrav - des@FreeBSD.org