Re: git: bd15d6ef126e - main - libarchive: Force GNU iconv compatibility on FreeBSD

From: Antoine Brodin <antoine_at_freebsd.org>
Date: Thu, 28 May 2026 07:08:16 UTC 
On Wed, May 27, 2026 at 3:17 PM Dag-Erling Smørgrav <des@freebsd.org> wrote:
>
> The branch main has been updated by des:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=bd15d6ef126ee4c0eac931117f6bbbf6f9a3fc72
>
> commit bd15d6ef126ee4c0eac931117f6bbbf6f9a3fc72
> Author:     Mark Johnston <markj@FreeBSD.org>
> AuthorDate: 2026-05-20 16:39:40 +0000
> Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
> CommitDate: 2026-05-27 13:10:57 +0000
>
>     libarchive: Force GNU iconv compatibility on FreeBSD
>
>     When libarchive is compiled with FreeBSD's native iconv instead of
>     libiconv, as happens with libarchive in the base system, we need to
>     configure iconv(3) to handle invalid sequences by returning -1, as
>     iconv_strncat_in_locale() assumes GNU iconv semantics.
>
>     This corresponds to upstream PR 3056.
>
>     PR:             294577
>     MFC after:      1 week

Hello,

Could this change break some ports?  (during previous run they were ok)
https://pkg-status.freebsd.org/beefy24/data/main-amd64-default/p50aa2c1cc258_s5a8e0e03ae8/logs/errors/py311-game-2.6.1_5.log
https://pkg-status.freebsd.org/beefy24/data/main-amd64-default/p50aa2c1cc258_s5a8e0e03ae8/logs/errors/py311-django52-5.2.14.log
https://pkg-status.freebsd.org/beefy24/data/main-amd64-default/p50aa2c1cc258_s5a8e0e03ae8/logs/errors/py311-django60-6.0.5.log
https://pkg-status.freebsd.org/beefy24/data/main-amd64-default/p50aa2c1cc258_s5a8e0e03ae8/logs/errors/aisleriot-3.22.35.log
etc.

Antoine