Re: git: 521fdb95cc78 - main - ossl: fix unused-function warning for AES_CBC_ENCRYPT on powerpc

On 8/17/26 20:12, Enji Cooper (yaneurabeya) wrote:
> 
>> On Aug 15, 2026, at 5:05 PM, Adrian Chadd <adrian@FreeBSD.org> wrote:
>>
>> oh crap my bad!
>>
>> i'll poke you on irc about it to figure out what to do next.
>>
>> thanks!
> 
> 	TY! For stuff like this it really should be pushed upstream unless we have a reason to keep local FreeBSD OpenSSL modifications. Given they have a CLA and a few other things for contributions.. it’s just easier for me to make the submission since I’ve already jumped through those hoops.
> Cheers,
> -Enji

Are you sure that is an upstream file?  The ossl_<arch>.h headers don't
really contain any upstream code (perhaps the list of flags constants
in the ppc one?).  In cases where an ossl* file is derived from OpenSSL
(most aren't) I used an explicit comment (e.g. "From crypto/foo/bar.c")
which these files are missing (I didn't create these particular headers,
they came in with the AES-CBC changes from Stormshield).  Most of the
upstream OpenSSL code in ossl(4) is in the assembly in the MD subdirectories
and the files without 'ossl' in their name such as arm_arch.h.

-- 
John Baldwin