From nobody Mon Aug 17 14:31:15 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hNwHn1FtJz6nsbh; Mon, 17 Aug 2026 14:31:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hNwHm6l7Xz3jkd; Mon, 17 Aug 2026 14:31:16 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786977076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=srhEpnBIUMoWd+AB8eiE/bS4zfmULKB6uQ1KxYpCKIw=; b=F7G4bNzzVe2XrKwPvd/bEjKqnR0NAG6/xG/S7zAqgtjXUsSQU1Kf06XaJ1tt6NDsmvQgpC g8gv/ESMqMJPFOlG9xySVX1MlrgsaZDL8Ker1A70QSK+XSgHiFNIcEyezC7+4bfCriPUjq NmoTe2kvC59ifwnVswZBwK1cC2mikUoimq7M9/yJRXMvmjRwFV05zr0iu/IqODKDF/x8QL Nah6j0Z6eprGZnv2uL8k+Soi9Q8BEtimupZn/9QYzMl7Ihdf/dkH4JKh7xkGG4br35/zco dPdN80UdaB4mX1ZLKS/wW30BryZrKTxBNBk5MRxmdgJvRqqb3qk8HHMPmE4GrQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786977076; a=rsa-sha256; cv=none; b=nEKA1Hm/tU/dgtYpNF9lB7H4n9Wuw/iJts7xLTIZOo8KfggTegpMNlzav0hh1emxXFStK0 Ehc+QL15w4cC+DlS90ZPlA3C7d6TQVRkTqRh+WKtmdW62yq6yj6QUila/mNgCp6/lIXoLr DC4k2duoEu7FB2YJDoWLerpAovyxeNqrbNV3C5sG3J58Jt2unR+O1R8PUCOp21laDpHXv9 LVGiQQS7tu3rzIQImCUTgMeQp1laX1NeOKHI6693HPgeoxVohenWEN4VSx7csWuQRit+rP JBFmrf1yFIJVcsqKWMkbshi86++Sn4YIhIKe/6eb8MUkNk8tds79yMStqpSTQA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786977076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=srhEpnBIUMoWd+AB8eiE/bS4zfmULKB6uQ1KxYpCKIw=; b=sYqX/0X1A4OoBQ2hXkQFdw/o4YGWtv8/3/KJnZLj/srZcOfGooojhV62FFid0UX+F9+7gs 2mDpFbEnpIfczvq5QwzlN5Nvn9ipCG0pHml2oeLYGEshlkF95vw0cdfgGyd75p1/4Z4Btu zPvFnwhIhHCN1wuYIZslKWbZrdpwhBMxhlms7Fvky+hzWJ4OmHQkesii1Prnjis2Vxallq 4YNSKZ9fYmKvOgSeqjnyXQV4ZhYloXr6OFQ92FvY8pN4QGbw2Y48DBBBnU2m1dj2rflRb0 EB26ABf6IgNHwL4c2nn+T5BkoNHUdF3yxWCxPvEpqdRCrp4pIOv35/AaV1QFIg== Received: from [IPV6:2601:5c0:4202:5670:c96d:e4c2:feef:9a90] (unknown [IPv6:2601:5c0:4202:5670:c96d:e4c2:feef:9a90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hNwHm3vNjztcZ; Mon, 17 Aug 2026 14:31:16 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <9141192b-2fe1-49df-ab24-2f1f7dc8270c@FreeBSD.org> Date: Mon, 17 Aug 2026 10:31:15 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 521fdb95cc78 - main - ossl: fix unused-function warning for AES_CBC_ENCRYPT on powerpc Content-Language: en-US To: "Enji Cooper (yaneurabeya)" , Adrian Chadd Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Abdelkader Boudih References: <6a808b7e.1c7cf.7cab605b@gitrepo.freebsd.org> <94D116BA-2C87-418A-840E-C5A684D26D88@gmail.com> <475036C0-2B3D-4B1D-928D-E6D9ED01B055@gmail.com> From: John Baldwin In-Reply-To: <475036C0-2B3D-4B1D-928D-E6D9ED01B055@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/17/26 20:12, Enji Cooper (yaneurabeya) wrote: > >> On Aug 15, 2026, at 5:05 PM, Adrian Chadd wrote: >> >> oh crap my bad! >> >> i'll poke you on irc about it to figure out what to do next. >> >> thanks! > > TY! For stuff like this it really should be pushed upstream unless we have a reason to keep local FreeBSD OpenSSL modifications. Given they have a CLA and a few other things for contributions.. it’s just easier for me to make the submission since I’ve already jumped through those hoops. > Cheers, > -Enji Are you sure that is an upstream file? The ossl_.h headers don't really contain any upstream code (perhaps the list of flags constants in the ppc one?). In cases where an ossl* file is derived from OpenSSL (most aren't) I used an explicit comment (e.g. "From crypto/foo/bar.c") which these files are missing (I didn't create these particular headers, they came in with the AES-CBC changes from Stormshield). Most of the upstream OpenSSL code in ossl(4) is in the assembly in the MD subdirectories and the files without 'ossl' in their name such as arm_arch.h. -- John Baldwin