Re: git: c867ba72889d - main - bnxt: Do not compile on 32-bit platforms

On Tue, May 28, 2024, 10:41 AM Jessica Clarke <jrtc27@freebsd.org> wrote:

> On 28 May 2024, at 14:13, Mark Johnston <markj@FreeBSD.org> wrote:
> >
> > The branch main has been updated by markj:
> >
> > URL:
> https://cgit.FreeBSD.org/src/commit/?id=c867ba72889de51b0bd2c6a7049f539abaafd46e
> >
> > commit c867ba72889de51b0bd2c6a7049f539abaafd46e
> > Author:     Mark Johnston <markj@FreeBSD.org>
> > AuthorDate: 2024-05-28 13:05:14 +0000
> > Commit:     Mark Johnston <markj@FreeBSD.org>
> > CommitDate: 2024-05-28 13:12:52 +0000
> >
> >    bnxt: Do not compile on 32-bit platforms
> >
> >    The new bnxt_re driver doesn't compile on any of them (it uses
> writeq()
> >    from the LinuxKPI, which isn't implemented there), and had already
> been
> >    disconnected from the build on i386.
> >
> >    Reported by:    Jenkins
> >    Fixes:  acd884dec99a ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
> > ---
> > sys/modules/Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/sys/modules/Makefile b/sys/modules/Makefile
> > index 54108097fe1d..d3ef4c63a41c 100644
> > --- a/sys/modules/Makefile
> > +++ b/sys/modules/Makefile
> > @@ -442,8 +442,8 @@ SUBDIR+= dtrace
> > SUBDIR+= opensolaris
> > .endif
> >
> > -# Requires bus_space_read_8
> > -.if ${MACHINE_ARCH} != "i386"
> > +.if ${MACHINE_ARCH} != "i386" && ${MACHINE_CPUARCH} != "arm" && \
> > +    ${MACHINE_ARCH} != "powerpc" && ${MACHINE_ARCH} != "powerpcspe"
>
> Check ${MACHINE_ABI:Mlong64} or !${MACHINE_ABI:Mlong32} instead?
>

Read 8 can be orthogonal to either of these... i thought we had it for
armv7 at least...

For this driver, though, any of the above are fine.

Warner

>