From nobody Tue May 28 17:09:19 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VpgYn62sXz5MqD5 for ; Tue, 28 May 2024 18:11:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VpgYn410Jz4Mqx for ; Tue, 28 May 2024 18:11:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a630ff4ac84so131987466b.1 for ; Tue, 28 May 2024 11:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1716919867; x=1717524667; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Rr24ohchHu3mrib6h/amzE/OBV8gvhLDhoy1ViEQ6zY=; b=A9Esvc0O/8SSco32fRW8vlI7Ux0ZPXWvFpcCPJQ86mD4LcS0BqwNU5gVAEnxYfdWnP EL06v9ZlRvhyepYM6LxODkE3HO9LImIGVQUO4me1P3oh6LYjnZj7gIV0twE06jYxNBWp QPFibicI9y0ytZl9e0DsJjuV83a0ycWLAj1ilBMxBx9Y5b6bZkXNM3tYsdLxlhZj9cXf I9kY+VTOdM2D4x/q1sDDb4/ByWUTqdsgN5ZGBRy3qZDC9wBTCmb/FJF5vkpNpgicJAuC h8ZIrsu/4GY+F1YElSTrR7atMO/c0WTxk7/wUtollDRmS0JZ5/nmHebeuIh4rmIbzMdC pLcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716919867; x=1717524667; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rr24ohchHu3mrib6h/amzE/OBV8gvhLDhoy1ViEQ6zY=; b=PiGiNGptAcQeSIR9Zqr3MNlhPjekftZINMRUrCIBlSzLWx756lsfAzFm853JeM8IQe v9ojYpyURKLomSwyZh2jqsTRlY30zJWaP9ZbuJ0ASTYzvECrdtgAfNpEjTiW3wGiEkcr +JsyUCn8LyqjbX6S/g2BNjL/FVTnPT4GYcCERpnQszbcuRfS0HlwK+ZSedi50fKk4SND 4atcVIiyCeAHqsgw2H/GiBw1IsUKE3uiv0Jfku5L7XM+w+5BGdwzckIw7sCec0xTiOXr n0QwzOJRxvXitiGZ2FJTnSxwFHVFSsvpsHSoRQG35DDMsid9iAJiArqxrYn2Krel8luH OvlQ== X-Forwarded-Encrypted: i=1; AJvYcCWPGTQFJ4PDk7Be04+jaJX9+oava75/WHtSp3LEl4PflUwmB87+jKGcffP0oxfXizPTNW3mC0D8ZvpWvSik20LuLUv8k4QFNd/JVCp2WdEA X-Gm-Message-State: AOJu0YwFckMRFj0YpasqMmXgoZC7DgjLegDQ5/v/Cq2HbD27iENpjV/J bX7+iz2WOKRxSCjzCMDhfT/pAm+o4znU/Vd7WE8ipqL7+7PBJdajB/RPku2td6jt44AP+gGgdui iQKn/aOP/haMlioXT7GOMduMyek2Ormz+V+797g== X-Google-Smtp-Source: AGHT+IHhWHBRJGXKJDmvgqN6lKDBNuK8X7qibGNvUGDGYnAk5yX2Qn1VtpXwlwPt4rLtAPbdp3gW/4aSgpG3TAMhSSc= X-Received: by 2002:a17:906:c7c7:b0:a52:3583:b9d0 with SMTP id a640c23a62f3a-a62641aa1cdmr800943266b.3.1716919867125; Tue, 28 May 2024 11:11:07 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202405281313.44SDD7VM021879@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Tue, 28 May 2024 11:09:19 -0600 Message-ID: Subject: Re: git: c867ba72889d - main - bnxt: Do not compile on 32-bit platforms To: Jessica Clarke Cc: Mark Johnston , src-committers , "" , "" Content-Type: multipart/alternative; boundary="000000000000c9d08e0619878eb9" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4VpgYn410Jz4Mqx --000000000000c9d08e0619878eb9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, May 28, 2024, 10:41=E2=80=AFAM Jessica Clarke = wrote: > On 28 May 2024, at 14:13, Mark Johnston wrote: > > > > The branch main has been updated by markj: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3Dc867ba72889de51b0bd2c6a7049f539= abaafd46e > > > > commit c867ba72889de51b0bd2c6a7049f539abaafd46e > > Author: Mark Johnston > > AuthorDate: 2024-05-28 13:05:14 +0000 > > Commit: Mark Johnston > > CommitDate: 2024-05-28 13:12:52 +0000 > > > > bnxt: Do not compile on 32-bit platforms > > > > The new bnxt_re driver doesn't compile on any of them (it uses > writeq() > > from the LinuxKPI, which isn't implemented there), and had already > been > > disconnected from the build on i386. > > > > Reported by: Jenkins > > Fixes: acd884dec99a ("RDMA/bnxt_re: Add bnxt_re RoCE driver") > > --- > > sys/modules/Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/sys/modules/Makefile b/sys/modules/Makefile > > index 54108097fe1d..d3ef4c63a41c 100644 > > --- a/sys/modules/Makefile > > +++ b/sys/modules/Makefile > > @@ -442,8 +442,8 @@ SUBDIR+=3D dtrace > > SUBDIR+=3D opensolaris > > .endif > > > > -# Requires bus_space_read_8 > > -.if ${MACHINE_ARCH} !=3D "i386" > > +.if ${MACHINE_ARCH} !=3D "i386" && ${MACHINE_CPUARCH} !=3D "arm" && \ > > + ${MACHINE_ARCH} !=3D "powerpc" && ${MACHINE_ARCH} !=3D "powerpcspe= " > > Check ${MACHINE_ABI:Mlong64} or !${MACHINE_ABI:Mlong32} instead? > Read 8 can be orthogonal to either of these... i thought we had it for armv7 at least... For this driver, though, any of the above are fine. Warner > --000000000000c9d08e0619878eb9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, May 28, 2024, 10:41=E2=80=AFAM Jessica Clarke = <jrtc27@freebsd.org> wrote:=
On 28 May 2024, at 14:13, Mark Joh= nston <markj@FreeBSD.org> wrote:
>
> The branch main has been updated by markj:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc867ba72889de51b0bd2c6a7049f53= 9abaafd46e
>
> commit c867ba72889de51b0bd2c6a7049f539abaafd46e
> Author:=C2=A0 =C2=A0 =C2=A0Mark Johnston <markj@FreeBSD.org>
> AuthorDate: 2024-05-28 13:05:14 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Mark Johnston <markj@FreeBSD.org>
> CommitDate: 2024-05-28 13:12:52 +0000
>
>=C2=A0 =C2=A0 bnxt: Do not compile on 32-bit platforms
>
>=C2=A0 =C2=A0 The new bnxt_re driver doesn't compile on any of them= (it uses writeq()
>=C2=A0 =C2=A0 from the LinuxKPI, which isn't implemented there), an= d had already been
>=C2=A0 =C2=A0 disconnected from the build on i386.
>
>=C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 Jenkins
>=C2=A0 =C2=A0 Fixes:=C2=A0 acd884dec99a ("RDMA/bnxt_re: Add bnxt_r= e RoCE driver")
> ---
> sys/modules/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sys/modules/Makefile b/sys/modules/Makefile
> index 54108097fe1d..d3ef4c63a41c 100644
> --- a/sys/modules/Makefile
> +++ b/sys/modules/Makefile
> @@ -442,8 +442,8 @@ SUBDIR+=3D dtrace
> SUBDIR+=3D opensolaris
> .endif
>
> -# Requires bus_space_read_8
> -.if ${MACHINE_ARCH} !=3D "i386"
> +.if ${MACHINE_ARCH} !=3D "i386" && ${MACHINE_CPUARC= H} !=3D "arm" && \
> +=C2=A0 =C2=A0 ${MACHINE_ARCH} !=3D "powerpc" && ${M= ACHINE_ARCH} !=3D "powerpcspe"

Check ${MACHINE_ABI:Mlong64} or !${MACHINE_ABI:Mlong32} instead?

Read 8 can = be orthogonal to either of these... i thought we had it for armv7 at least.= ..

For this driver, thou= gh, any of the above are fine.

Warner
--000000000000c9d08e0619878eb9--