Re: git: c21bc6f3c242 - main - ddb: Add CTF-based pretty printing

From: Mitchell Horne <mhorne_at_freebsd.org>
Date: Fri, 22 Mar 2024 16:31:41 UTC 

On 3/22/24 04:38, Baptiste Daroussin wrote:
> On Fri 22 Mar 03:56, Bojan Novković wrote:
>> The branch main has been updated by bnovkov:
>>
>> URL: https://cgit.FreeBSD.org/src/commit/?id=c21bc6f3c2425de74141bfee07b609bf65b5a6b3
>>
>> commit c21bc6f3c2425de74141bfee07b609bf65b5a6b3
>> Author:     Bojan Novković <bnovkov@FreeBSD.org>
>> AuthorDate: 2024-03-22 03:01:34 +0000
>> Commit:     Bojan Novković <bnovkov@FreeBSD.org>
>> CommitDate: 2024-03-22 03:03:33 +0000
>>
>>      ddb: Add CTF-based pretty printing
>>      
>>      Add basic CTF support and a CTF-powered pretty-printer to ddb.
>>      
>>      The db_ctf.* files expose a basic interface for fetching type
>>      data for ELF symbols, interacting with the CTF string table,
>>      and translating type identifiers to type data.
>>      
>>      The db_pprint.c file uses those interfaces to implement
>>      a pretty-printer for all kernel ELF symbols.
>>      The pretty-printer works with symbol names and arbitrary addresses:
>>      pprint struct thread 0xffffffff8194ad90
>>      
>>      Pretty-printing currently only works after the root filesystem
>>      gets mounted because the CTF info is not available during
>>      early boot.
>>      
>>      Differential Revision:  https://reviews.freebsd.org/D37899
>>      Approved by: markj (mentor)
> 
> This breaks building kernel MINIMAL
> 
> ld: error: undefined symbol: db_ctf_lookup_typename
> 
> Best regards,
> Bapt

This should be addressed by dc7ae2bc6fadd.

Bojan, please have a look to ensure that it was done correctly.

Cheers,
Mitchell