From nobody Fri Mar 22 16:31:41 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V1SWy2MbQz5FJ4h; Fri, 22 Mar 2024 16:31:42 +0000 (UTC) (envelope-from mhorne@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V1SWy1w5nz4Zj9; Fri, 22 Mar 2024 16:31:42 +0000 (UTC) (envelope-from mhorne@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711125102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Yz1z6FxFrRLRPOCygseqHnCGrIY2t81BarLIlkGCOL8=; b=Yi2lcapyevXFB9MK1YrifGurzvxR6EOMRTxXaGpDq24I6umRhE4dUt5uYm8WKa5CGEeXR7 WjoX/iDfKHqNI+Dq7NTJ25bT+tchCDx7xKy5ptVGnNC+kwyWVgDxIaebgKlFXYV3kVASfa yDzlCOu/9bkv2sOLrg/rx87rjCh5SN1wDMQCKd84Dfa8Bbw/Kx7rv7TZvh9vFa5pm1pc2U dKMGxg0hs6K0fF3zifkOECexXoaWBVJZqRyQVIMa3hXuicokOPDlXbecDOkKV0fGZyY3IR mqj0ywOcPGyidcTA8m0LWxdM1IlMJjsrlvI+JiO9rHTSKhNUjEr9U4jposW7ew== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711125102; a=rsa-sha256; cv=none; b=k1koYxp+IgrzZz1nQ09fEXW1FNDvy8kYSKfmF9KglDVFuVRUYywpeOKWu92YuvUdiAQmZJ S0tbzNt3tiAZTIXkcJrZWCnSSrSwq8FNkEvijbkg16PkJIXMsQERbSKlSvSzd2YrPBq0sh 4wI3AzxTMN+fMJe0ilLjnZ7ZJoZWtJrbWjxG4qznFGfLdfW7stutedHAWM2GRnDOkdr9s6 s9QrVc42S0nyykslBGL8XkVTXcbCYpsHWTA2LvgNtLlU8cHq99iHdTaxDBjuwuBjWNEIRe p3YtbGuCo17727vhs2FpQvKxS4Kyx6CY2EIO6B5nZCP/w5gKDqWoY3cLdDp55w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711125102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Yz1z6FxFrRLRPOCygseqHnCGrIY2t81BarLIlkGCOL8=; b=jjJ77mOe2GlxVIVafjhVPYcdAi4OKbP+ZdaoKdOA3XEy9jg4SuXK0kY9XCJu/BdINIkww6 FHz8kGypm/Jt/YOavWSh+9Q11epjyNpytPKx7HWZyxIk6XLR2VJJoMT7Loh+71mOeRwNYH /nSfWZvlldTcKyd+yHox0L9KWXWKzPY3pt0Atwfl6mJV1mPT4BHKfmb8fAFuGMKqZ9cKT7 uWn+JxvuD5fkPCgs+EDHc8pDYLOKf2qmCKuFD2P+n4dS02cAm01GBpIQWJElCGei45Rhz2 Tj+BTyCp6RKXX0OtpxD0POzmw6Pa0AyICJCUoIUtX4ROtiYpFz6tpEOgHyCOOQ== Received: from [192.168.1.151] (host-173-212-76-127.public.eastlink.ca [173.212.76.127]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mhorne) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V1SWx6YwZz1Wr9; Fri, 22 Mar 2024 16:31:41 +0000 (UTC) (envelope-from mhorne@freebsd.org) Message-ID: <555d3b44-8193-473e-ba68-5b37aff43a37@freebsd.org> Date: Fri, 22 Mar 2024 13:31:41 -0300 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: c21bc6f3c242 - main - ddb: Add CTF-based pretty printing Content-Language: en-CA To: Baptiste Daroussin , =?UTF-8?Q?Bojan_Novkovi=C4=87?= Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202403220356.42M3uJh3021416@gitrepo.freebsd.org> From: Mitchell Horne Autocrypt: addr=mhorne@freebsd.org; keydata= xsBNBFyS2dQBCADdiXBG8hBVLmYbxu7aSzbwLwUf3HkGFz3rooS1kwyy+SfmjZ4UKNnl9WMx WKrJ7OAZpiNH6bLQ5nsqfx09OnpWL8c/QuPbhNdUywQoqqYpRI0K8GEn//nS9Gs0KTYwVpWb XlrzP+jf3Uh/9L5mcQmStLIH4zaaqMYHW+pMuPrvBmLIHTvLj2QjOkxslrcUdord9uvxe5Ht LU8RuTpQpHOKz705Z9/v7twFdi2HtKzpLwO6SzVyu351di1J+GihsVpcT5josQV5cHbIP3Un x+kmtKBEEc/jl/zBglF7ruWUtwgbryID+2ZPEaO1Mj+RResX4LFVMusq3uUpWRb5WJXxABEB AAHNI01pdGNoZWxsIEhvcm5lIDxtaG9ybmVARnJlZUJTRC5vcmc+wsCUBBMBCgA+AhsDBQsJ CAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEkp/cYPcfabAiQvACi/gnTOdUid8FAmIyDpUFCQtC z0EACgkQi/gnTOdUid8IsQf+N8IptrrCgifT5Z0/WUVFfnHThFOKf4zBjaGswsIM8+VKsKnF 15jCWHODUHP6s+dcQ4nQi81PHPsnMfBSkGPvN/X3ess2/1KUVkH+6tAJbqXDjXhD8HT+i0NM QEFIXlLnotpgIKW3yOHjKv3ZvKw9LCvUjyNY9vOJmLk/6AbbkFh+INo65nXtQWb/hM5FVEHW S+zUoU8AqZRJoVAQfj9wmIfg/HdsxeDGKL0zkv5AwKpccvb8VJNGJbCVMgoy5uQYcUeXxcie cg0VlbFLshNQTfyhVQ85vyuHahARrUWs/k8KiYODoBnW1ChtyF8yM6VZTzSYx7pINqPq2YZy i/Htd87ATQRcktnUAQgA3zt4M4ecoQqfxpjliNLujt9klDqvmkJvWmzMuMXdzlPgGRJ0doio 9YIeEdkOt6xN0pPTK/ReCZ8WqFQ8zo23u1pwGuo0CnR58XF19wyxyUuKu/PHbt+56mC8tNHm AXsMyXQmlDqWvn/WzLY7euNRtNS4QQIwtxfM5EC4GGa5KQwxn0kM7dkUSOE/cxr+/kNbHHzb gagZR4cnNUqtPPr3dYXcibCTzgz96Lyt3/qMLXX9RTBRzu+O6E+byxWOe8ar/ZlwY2b4wTQG mhgNttkSxKtxMpZnd8+DGV/bI1P5Ct/K2GeCwNyupQGON5ymn6o7jTch+qmFX0ItkBWO4zn4 9QARAQABwsB8BBgBCgAmAhsMFiEEkp/cYPcfabAiQvACi/gnTOdUid8FAmIyDtwFCQtCz4gA CgkQi/gnTOdUid/i5gf/aQ75pJR4TJFM2vVVr6PDIwTdl0b5EchB4w4s4g/zE84XNbMOQanb BginLYEhAacLQVAvM3XdvUEhwrhaMQdjdSEB1krResL3/mbxrtKwdHSMbHA3IS3XdvxFWTB7 P5JjUSPsW6hqgoidbn4w3OxaNHhs45H2b0Nx5QiKcSyepmCZuB52gCEHnEnrdaz8TFQMXOLq 94WbTmZeIjChW3FB61m1gTf0UEFjoZAfTAUB+pbwoCa4AykIeZnDC19vjsruVU9Gy5rLglwd bjsZNfXIJGOZNEvdF8FOBwM7DlXx7SYvTJcUNoNJjOKtQ0bYGVgGqYOB/y2mTjVuKeU0eOkN Uw== In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/22/24 04:38, Baptiste Daroussin wrote: > On Fri 22 Mar 03:56, Bojan Novković wrote: >> The branch main has been updated by bnovkov: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=c21bc6f3c2425de74141bfee07b609bf65b5a6b3 >> >> commit c21bc6f3c2425de74141bfee07b609bf65b5a6b3 >> Author: Bojan Novković >> AuthorDate: 2024-03-22 03:01:34 +0000 >> Commit: Bojan Novković >> CommitDate: 2024-03-22 03:03:33 +0000 >> >> ddb: Add CTF-based pretty printing >> >> Add basic CTF support and a CTF-powered pretty-printer to ddb. >> >> The db_ctf.* files expose a basic interface for fetching type >> data for ELF symbols, interacting with the CTF string table, >> and translating type identifiers to type data. >> >> The db_pprint.c file uses those interfaces to implement >> a pretty-printer for all kernel ELF symbols. >> The pretty-printer works with symbol names and arbitrary addresses: >> pprint struct thread 0xffffffff8194ad90 >> >> Pretty-printing currently only works after the root filesystem >> gets mounted because the CTF info is not available during >> early boot. >> >> Differential Revision: https://reviews.freebsd.org/D37899 >> Approved by: markj (mentor) > > This breaks building kernel MINIMAL > > ld: error: undefined symbol: db_ctf_lookup_typename > > Best regards, > Bapt This should be addressed by dc7ae2bc6fadd. Bojan, please have a look to ensure that it was done correctly. Cheers, Mitchell