Re: git: 67f2a563bfca - main - acpi: Tell SMM we will handle CPPC notifications

On Tue, Oct 11, 2022 at 8:32 AM Tom Jones <thj@freebsd.org> wrote:

> On Tue, Oct 11, 2022 at 07:32:47AM -0600, Warner Losh wrote:
> > On Tue, Oct 11, 2022 at 2:33 AM Tom Jones <thj@freebsd.org> wrote:
> >
> > > >
> > > > This isn’t under an ifdef?
> > > >
> > > > Jess
> > > >
> > >
> > > It should be, thanks for pointing it out. I've fixed it now.
> > >
> > > I hope when we get support for CPPC on arm64 we don't have this sort of
> > > issue too.
> > >
> >
> > Is CPPC missing completely? IF so, then ignore the suggestion I made on
> the
> > #ifdef.
>
> I am not aware that we have support, a quick google didn't show anything
> up. Linux does have support, the initial review I found looked like
> quite a bit of work.
>
> If no one shouts I am going to leave this for now, we can always expand
> scope in the future.
>

OK. In that case, you need to ifdef the
> +static bool           cppc_notify;
line, otherwise many compilers will complain that it's not used on !x86

Warner


> - Tom
>