From nobody Tue Oct 11 15:04:30 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MmzbH63zdz4dfTQ for ; Tue, 11 Oct 2022 15:04:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MmzbH5fl5z3rB6 for ; Tue, 11 Oct 2022 15:04:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ej1-x62f.google.com with SMTP id ot12so32089346ejb.1 for ; Tue, 11 Oct 2022 08:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=++O/tl6hJIJQx6wE3IhCBo+4n95pMddv2z920S6cd30=; b=1o6uAlyKv1C608NQlwQPLGtnnUyXdAMy7YS9P/4XNASRR+P3L3gSUr+sw7f1T5Fjn/ 3pIfZuKmm1RLfuTyCD/8anj7HQCh+7BI+4NPC+oLtZEOQoWfo130M39lGSGA9xDesk+W SMG0v8NoKrhiNq8WvyLg+9khYBw0/uCfCKK2aNCrU6f6Gfrb9zOVuA9oIlU2Rq+1liTt CajttMMK5B/RrGNxde1nlvn/IvKoyKaTBwJ994tc61PU37SdZePycGolpyzLqsHmMaAR DnBMhZN1KCiYToMQkJ+e2ORc2SCaljO4UElW2ouVkfWsCSf3wncXgNpCtN48nms8Cght yOKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=++O/tl6hJIJQx6wE3IhCBo+4n95pMddv2z920S6cd30=; b=p2tRhEYkYb4EWlMdH9pLIeen0HnfTRHygsEwcMjeDeAQUF6zpUoLezo+5iVIl2hS/m 14w0Zx8Uvp+1C7xPxtzKQEaCwqZY7P62o3J5LSA2EOItvNx3JQgAJL115TE04ucMVWTu NBnajAERmscyxwgBVq3W2TIWN9MiVX8V3+WqUJV21Zsnu4p+HDdM1EPu7bq0VD2vZMbl p/PDlDRbr2slRSFJD6VyRpejyuW66ilCNZPLZntMEoQmiMgVnJLK158LeQCyxQk5xULe ZdT3xt7V/4S39fBA+QjEa4a6FF/pQVc4AayPaYGE1XhgicfBCiqPy1JbyvyVV7tUT3Vh qZNw== X-Gm-Message-State: ACrzQf2vINxBSRM6go2nJNX1hD1jGp5ZyIvVMRMZI+9EHe3SLbizAx9z zUnnf41SEqI3qL5XGDVs5LtlIR8gdVguz+RKnSztlg== X-Google-Smtp-Source: AMsMyM7jZFRuE5bUEu/8qTj4YLbuZPgKjpVYHfo0UKzvBvLbVjuzGr49yqNHApB/WFqOzsWFj7wy9ph+nwMYt7TPUug= X-Received: by 2002:a17:907:968b:b0:78d:c3cb:8b9b with SMTP id hd11-20020a170907968b00b0078dc3cb8b9bmr6785640ejc.252.1665500682489; Tue, 11 Oct 2022 08:04:42 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202210101353.29ADrhXG012590@gitrepo.freebsd.org> <2963DD27-E730-445D-BD59-0DB728CDA203@freebsd.org> In-Reply-To: From: Warner Losh Date: Tue, 11 Oct 2022 09:04:30 -0600 Message-ID: Subject: Re: git: 67f2a563bfca - main - acpi: Tell SMM we will handle CPPC notifications To: Tom Jones Cc: Jessica Clarke , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="0000000000008dad9705eac39890" X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4MmzbH5fl5z3rB6 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --0000000000008dad9705eac39890 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Oct 11, 2022 at 8:32 AM Tom Jones wrote: > On Tue, Oct 11, 2022 at 07:32:47AM -0600, Warner Losh wrote: > > On Tue, Oct 11, 2022 at 2:33 AM Tom Jones wrote: > > > > > > > > > > This isn=E2=80=99t under an ifdef? > > > > > > > > Jess > > > > > > > > > > It should be, thanks for pointing it out. I've fixed it now. > > > > > > I hope when we get support for CPPC on arm64 we don't have this sort = of > > > issue too. > > > > > > > Is CPPC missing completely? IF so, then ignore the suggestion I made on > the > > #ifdef. > > I am not aware that we have support, a quick google didn't show anything > up. Linux does have support, the initial review I found looked like > quite a bit of work. > > If no one shouts I am going to leave this for now, we can always expand > scope in the future. > OK. In that case, you need to ifdef the > +static bool cppc_notify; line, otherwise many compilers will complain that it's not used on !x86 Warner > - Tom > --0000000000008dad9705eac39890 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Oct 11, 2022 at 8:32 AM Tom J= ones <thj@freebsd.org> wrote:<= br>
On Tue, Oct 11, = 2022 at 07:32:47AM -0600, Warner Losh wrote:
> On Tue, Oct 11, 2022 at 2:33 AM Tom Jones <thj@freebsd.org> wrote:
>
> > >
> > > This isn=E2=80=99t under an ifdef?
> > >
> > > Jess
> > >
> >
> > It should be, thanks for pointing it out. I've fixed it now.<= br> > >
> > I hope when we get support for CPPC on arm64 we don't have th= is sort of
> > issue too.
> >
>
> Is CPPC missing completely? IF so, then ignore the suggestion I made o= n the
> #ifdef.

I am not aware that we have support, a quick google didn't show anythin= g
up. Linux does have support, the initial review I found looked like
quite a bit of work.

If no one shouts I am going to leave this for now, we can always expand
scope in the future.

OK. In that case, = you need to ifdef the=C2=A0
> +static bool=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0cppc_notify;
line, otherwise many compil= ers will complain that it's not used on !x86

W= arner
=C2=A0
- Tom
--0000000000008dad9705eac39890--