Re: git: 62d42655bca1 - main - usb(4): Substitute "unsigned int" using the equivalent and shorter "unsigned" keyword.
Date: Fri, 07 Oct 2022 14:48:29 UTC
On Fri, Oct 7, 2022 at 8:21 AM Hans Petter Selasky <hps@selasky.org> wrote: > On 10/7/22 15:21, Piotr P. Stefaniak wrote: > > On 2022-10-07 14:03:51, Hans Petter Selasky wrote: > >> On 10/7/22 13:48, Piotr P. Stefaniak wrote: > >>> On 2022-10-07 11:41:38, Hans Petter Selasky wrote: > >>> > >>>> usb(4): Substitute "unsigned int" using the equivalent and shorter > >>>> "unsigned" keyword. > >>> > >>> Why? Just because it's shorter? > >> > >> Yes, just because "int" is the redundant. > > > > Definitely that's true for computers. In case of humans it's debatable. > > Would uint32_t be more clear? > I don't think it would be that much clearer. The only places I might be tempted to use uint32_t is for any of the structs that were unsigned int that are externally defined to be 32-bit unsigned integers, which is a tiny fraction of what you changed (I noticed only a few structures and I didn't look further to see if they are internal to the USB stack, or data returned from a device). Warner