Re: git: 92b3e07229ba - main - Enable net.inet.tcp.nolocaltimewait.

From: Kubilay Kocak <koobs_at_FreeBSD.org>
Date: Sat, 30 Oct 2021 00:25:12 UTC
On 29/10/2021 9:35 am, Gleb Smirnoff wrote:
> The branch main has been updated by glebius:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=92b3e07229baab17cbe258ff1081e66bb7913b31
> 
> commit 92b3e07229baab17cbe258ff1081e66bb7913b31
> Author:     Gleb Smirnoff <glebius@FreeBSD.org>
> AuthorDate: 2021-10-28 22:34:00 +0000
> Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
> CommitDate: 2021-10-28 22:34:00 +0000
> 
>      Enable net.inet.tcp.nolocaltimewait.
>      
>      This feature has been used for many years at large sites and
>      didn't show any pitfalls.
> ---
>   sys/netinet/tcp_timewait.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sys/netinet/tcp_timewait.c b/sys/netinet/tcp_timewait.c
> index 5d4de222b802..9d397d62424f 100644
> --- a/sys/netinet/tcp_timewait.c
> +++ b/sys/netinet/tcp_timewait.c
> @@ -176,10 +176,10 @@ SYSCTL_PROC(_net_inet_tcp, OID_AUTO, maxtcptw,
>       &maxtcptw, 0, sysctl_maxtcptw, "IU",
>       "Maximum number of compressed TCP TIME_WAIT entries");
>   
> -VNET_DEFINE_STATIC(int, nolocaltimewait) = 0;
> +VNET_DEFINE_STATIC(bool, nolocaltimewait) = true;
>   #define	V_nolocaltimewait	VNET(nolocaltimewait)
> -SYSCTL_INT(_net_inet_tcp, OID_AUTO, nolocaltimewait, CTLFLAG_VNET | CTLFLAG_RW,
> -    &VNET_NAME(nolocaltimewait), 0,
> +SYSCTL_BOOL(_net_inet_tcp, OID_AUTO, nolocaltimewait, CTLFLAG_VNET | CTLFLAG_RW,
> +    &VNET_NAME(nolocaltimewait), true,
>       "Do not create compressed TCP TIME_WAIT entries for local connections");
>   
>   void
> 

RELNOTES: ?