From nobody Sat Oct 30 00:25:12 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7969D18323D1; Sat, 30 Oct 2021 00:25:24 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hh0SM4mLTz3CVS; Sat, 30 Oct 2021 00:25:23 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pj1-x102d.google.com with SMTP id ls14-20020a17090b350e00b001a00e2251c8so8425356pjb.4; Fri, 29 Oct 2021 17:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=L9p63o0ivQwCQ2C4acrBRBMiTFQl4oYFhCvE0qTGaKw=; b=ZC+VUU1wRSSOHmB/L7sDlWzEd0v7/an5RZOj1/U1WAmRE/BrgQ0myvYeJoxC4gIa7N MCkQqP73qDtNsYR+otpot5iCguho1TNf2dmdBqoYWT87khBlifx1X/x8aJamSzWKaHc6 Z/xHI03NdaFq71dfpUGRBKdxqfHP/Obr8fIDuQ3uVaye70kjxzHXHhc4XKJ+D8Y/TCNx e43iIAC8iXKQjdbgYQvR9TYjpdJLSxNny2TF1WY7TtrR2enq/GWXTV301Xazrs3DmQUc uYTQSKTqIfg6em1Oc/cyKZ7wXfbM6R9JYMtKzkMRjoioQJSDFh/bUBka3+J41xIsRVFs Orlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :reply-to:subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=L9p63o0ivQwCQ2C4acrBRBMiTFQl4oYFhCvE0qTGaKw=; b=KJaFh1QySN9EoRbYh+yw5FxqutXpk5Y/fIIhRrTHfseBuV58MVK7hONAVp7ntfsJK7 NF41WWabcyFqczOERY9R4jnMjPGUQ/q3eGKWQbtluZ9FTgoZBQS8f7z9OoKabLxj+Fat F72+MHYnIvuJ7F61B2/Txe6VvYZqrtF/UhGo9BUPqpZnd7jruqxh0v+C76Wn8GyQCZaS Laly0Q846g0tU/ulH06f9zmULB86d3XIqsKqkYZ55qZNA2DHkfvMOD8H5JQ+eWDFpypE 1cfVHnDSW57NFtburq7059lDWnLdMzoJoNDwZWkLrZ/0dYI0mqwL46WMvhyGcc4uZ1Op EQkw== X-Gm-Message-State: AOAM530ssT/FQ/acyv0rA/BAToelSW18AckqUYdfgT0L/Sv0z6gkQ/SU kIMt1VAo/TTNoUTnkh+QujHfGBVhUPM= X-Google-Smtp-Source: ABdhPJzAUWy/j9iwkpnMy/sRVa1jvRj619E36uLypFg+bJiltBmK7+bAD/h9WBMgqGuHD/Y0d4CqrQ== X-Received: by 2002:a17:902:db02:b0:141:b1dd:111 with SMTP id m2-20020a170902db0200b00141b1dd0111mr5382261plx.44.1635553517053; Fri, 29 Oct 2021 17:25:17 -0700 (PDT) Received: from ?IPV6:2403:5807:1b:1:29fd:8863:3b42:c493? (2403-5807-1b-1-29fd-8863-3b42-c493.ip6.aussiebb.net. [2403:5807:1b:1:29fd:8863:3b42:c493]) by smtp.gmail.com with ESMTPSA id c1sm4926775pfv.54.2021.10.29.17.25.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Oct 2021 17:25:16 -0700 (PDT) Sender: Kubilay Kocak Message-ID: Date: Sat, 30 Oct 2021 11:25:12 +1100 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:95.0) Gecko/20100101 Thunderbird/95.0a1 Reply-To: koobs@FreeBSD.org Subject: Re: git: 92b3e07229ba - main - Enable net.inet.tcp.nolocaltimewait. Content-Language: en-US To: Gleb Smirnoff , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202110282235.19SMZoAL076017@gitrepo.freebsd.org> From: Kubilay Kocak In-Reply-To: <202110282235.19SMZoAL076017@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Hh0SM4mLTz3CVS X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZC+VUU1w; dmarc=none; spf=pass (mx1.freebsd.org: domain of koobsfreebsd@gmail.com designates 2607:f8b0:4864:20::102d as permitted sender) smtp.mailfrom=koobsfreebsd@gmail.com X-Spamd-Result: default: False [-3.20 / 15.00]; HAS_REPLYTO(0.00)[koobs@FreeBSD.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; FROM_NEQ_ENVFROM(0.00)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::102d:from]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 29/10/2021 9:35 am, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: https://cgit.FreeBSD.org/src/commit/?id=92b3e07229baab17cbe258ff1081e66bb7913b31 > > commit 92b3e07229baab17cbe258ff1081e66bb7913b31 > Author: Gleb Smirnoff > AuthorDate: 2021-10-28 22:34:00 +0000 > Commit: Gleb Smirnoff > CommitDate: 2021-10-28 22:34:00 +0000 > > Enable net.inet.tcp.nolocaltimewait. > > This feature has been used for many years at large sites and > didn't show any pitfalls. > --- > sys/netinet/tcp_timewait.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sys/netinet/tcp_timewait.c b/sys/netinet/tcp_timewait.c > index 5d4de222b802..9d397d62424f 100644 > --- a/sys/netinet/tcp_timewait.c > +++ b/sys/netinet/tcp_timewait.c > @@ -176,10 +176,10 @@ SYSCTL_PROC(_net_inet_tcp, OID_AUTO, maxtcptw, > &maxtcptw, 0, sysctl_maxtcptw, "IU", > "Maximum number of compressed TCP TIME_WAIT entries"); > > -VNET_DEFINE_STATIC(int, nolocaltimewait) = 0; > +VNET_DEFINE_STATIC(bool, nolocaltimewait) = true; > #define V_nolocaltimewait VNET(nolocaltimewait) > -SYSCTL_INT(_net_inet_tcp, OID_AUTO, nolocaltimewait, CTLFLAG_VNET | CTLFLAG_RW, > - &VNET_NAME(nolocaltimewait), 0, > +SYSCTL_BOOL(_net_inet_tcp, OID_AUTO, nolocaltimewait, CTLFLAG_VNET | CTLFLAG_RW, > + &VNET_NAME(nolocaltimewait), true, > "Do not create compressed TCP TIME_WAIT entries for local connections"); > > void > RELNOTES: ?