Re: git: 225639e7db68 - main - vt: Disable bell by default

From: Slawa Olhovchenkov <slw_at_zxy.spb.ru>
Date: Wed, 20 Oct 2021 12:15:32 UTC
On Wed, Oct 20, 2021 at 01:42:37PM +0200, Emmanuel Vadot wrote:

> On Wed, 20 Oct 2021 12:52:06 +0300
> Slawa Olhovchenkov <slw@zxy.spb.ru> wrote:
> 
> > On Tue, Oct 19, 2021 at 01:37:00PM +0200, Emmanuel Vadot wrote:
> > 
> > > On Tue, 19 Oct 2021 14:21:33 +0300
> > > Slawa Olhovchenkov <slw@zxy.spb.ru> wrote:
> > > 
> > > > On Tue, Oct 19, 2021 at 07:38:15AM +0000, Emmanuel Vadot wrote:
> > > > 
> > > > > The branch main has been updated by manu:
> > > > > 
> > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=225639e7db685a4047e384abdbc296c0e02bd147
> > > > > 
> > > > > commit 225639e7db685a4047e384abdbc296c0e02bd147
> > > > > Author:     Emmanuel Vadot <manu@FreeBSD.org>
> > > > > AuthorDate: 2021-10-18 08:16:41 +0000
> > > > > Commit:     Emmanuel Vadot <manu@FreeBSD.org>
> > > > > CommitDate: 2021-10-19 07:37:28 +0000
> > > > > 
> > > > >     vt: Disable bell by default
> > > > >     
> > > > >     Bell is either useless if you're working on remote servers or really annoying
> > > > >     when you're working with a local machine that have a loud buzzer.
> > > > >     Switch the default to have it disable.
> > > > 
> > > > For you, not for me, for example. Also, this is violate POLA.
> > > 
> > >  Just set kern.vt.enable_bell=1 in /etc/sysctl.conf and you will be
> > > happy again. I'll do some UPDATING note.
> > >  And POLA doesn't means that we can't change a thing.
> > 
> > Modify bsdinstall to set kern.vt.enable_bell=0 in /etc/sysctl.conf,
> > this is don't break POLA for updating existing install and be happy you.
> 
>  Stop using POLA for "This is a change that I don't agree with".
>  In the past weeks we had commits that changed mixer(8) cli in a
> non-backward compatible way and changed the root shell. For both you
> haven't complain so it means that either you don't care or you agree
> with those changes.

root shell change promises same behavior as present (and don't changed
on existing install w/o manual confirm by etcupdate), mixer cli don't
used by me daily (every time I am read manual)

>  I agree that the bell is clearly a user preference and also I could
> have left the review opened for more time (but I've been there and
> usually you have review/feedback the first day and after it's silent).
> I wish there was an easy way for developer (and community member) to
> create a poll for changes like that but we don't have one right now.
>  Now based on the number of people who reviewed and the people who sent
> me private message to thanks me for this change I think that more
> people are annoyed by the bell than people who wants it and we want
> sane default that most users agrees on in base FreeBSD. If you don't
> agree with the defaults we have a way to change them.

I am say not about for new install, I am say about change behavior of
existing install after upgrade to 14. Modify bsdinstall satisfy people
are annoyed by the bell and don't touch people accepted bell on
existing install. win-win mostly.