From nobody Wed Oct 20 12:15:32 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1C4D3180AD6B; Wed, 20 Oct 2021 12:15:41 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4HZ8hX6bNVz3nxd; Wed, 20 Oct 2021 12:15:40 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1mdAVI-0006k6-NJ; Wed, 20 Oct 2021 15:15:32 +0300 Date: Wed, 20 Oct 2021 15:15:32 +0300 From: Slawa Olhovchenkov To: Emmanuel Vadot Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 225639e7db68 - main - vt: Disable bell by default Message-ID: <20211020121532.GX33191@zxy.spb.ru> References: <202110190738.19J7cFtw067994@gitrepo.freebsd.org> <20211019112132.GC80160@zxy.spb.ru> <20211019133700.77c0ca7ac488eb99df50551b@bidouilliste.com> <20211020095206.GA77338@zxy.spb.ru> <20211020134237.17596440e1fabda5d40f6985@bidouilliste.com> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211020134237.17596440e1fabda5d40f6985@bidouilliste.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-Rspamd-Queue-Id: 4HZ8hX6bNVz3nxd X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, Oct 20, 2021 at 01:42:37PM +0200, Emmanuel Vadot wrote: > On Wed, 20 Oct 2021 12:52:06 +0300 > Slawa Olhovchenkov wrote: > > > On Tue, Oct 19, 2021 at 01:37:00PM +0200, Emmanuel Vadot wrote: > > > > > On Tue, 19 Oct 2021 14:21:33 +0300 > > > Slawa Olhovchenkov wrote: > > > > > > > On Tue, Oct 19, 2021 at 07:38:15AM +0000, Emmanuel Vadot wrote: > > > > > > > > > The branch main has been updated by manu: > > > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=225639e7db685a4047e384abdbc296c0e02bd147 > > > > > > > > > > commit 225639e7db685a4047e384abdbc296c0e02bd147 > > > > > Author: Emmanuel Vadot > > > > > AuthorDate: 2021-10-18 08:16:41 +0000 > > > > > Commit: Emmanuel Vadot > > > > > CommitDate: 2021-10-19 07:37:28 +0000 > > > > > > > > > > vt: Disable bell by default > > > > > > > > > > Bell is either useless if you're working on remote servers or really annoying > > > > > when you're working with a local machine that have a loud buzzer. > > > > > Switch the default to have it disable. > > > > > > > > For you, not for me, for example. Also, this is violate POLA. > > > > > > Just set kern.vt.enable_bell=1 in /etc/sysctl.conf and you will be > > > happy again. I'll do some UPDATING note. > > > And POLA doesn't means that we can't change a thing. > > > > Modify bsdinstall to set kern.vt.enable_bell=0 in /etc/sysctl.conf, > > this is don't break POLA for updating existing install and be happy you. > > Stop using POLA for "This is a change that I don't agree with". > In the past weeks we had commits that changed mixer(8) cli in a > non-backward compatible way and changed the root shell. For both you > haven't complain so it means that either you don't care or you agree > with those changes. root shell change promises same behavior as present (and don't changed on existing install w/o manual confirm by etcupdate), mixer cli don't used by me daily (every time I am read manual) > I agree that the bell is clearly a user preference and also I could > have left the review opened for more time (but I've been there and > usually you have review/feedback the first day and after it's silent). > I wish there was an easy way for developer (and community member) to > create a poll for changes like that but we don't have one right now. > Now based on the number of people who reviewed and the people who sent > me private message to thanks me for this change I think that more > people are annoyed by the bell than people who wants it and we want > sane default that most users agrees on in base FreeBSD. If you don't > agree with the defaults we have a way to change them. I am say not about for new install, I am say about change behavior of existing install after upgrade to 14. Modify bsdinstall satisfy people are annoyed by the bell and don't touch people accepted bell on existing install. win-win mostly.