Re: git: b991d37c58ed - main - graphics/wayland: Remove libm from pkgconfig Libs

On Mon, 11 Aug 2025 01:34:03 -0400
"Jason E. Hale" <jhale@freebsd.org> wrote:

> On Sat, Aug 9, 2025 at 9:59?AM Max Brazhnikov <makc@freebsd.org> wrote:
> >
> > On Sat, 9 Aug 2025 15:21:54 +0200 Emmanuel Vadot wrote:
> > > On Sat, 09 Aug 2025 14:11:34 +0300
> > > Max Brazhnikov <makc@freebsd.org> wrote:
> > >
> > > > On Fri, 08 Aug 2025 15:07:58 +0200 Jan Beich wrote:
> > > > > Emmanuel Vadot <manu@FreeBSD.org> writes:
> > > > >
> > > > > >     This changes seems to confuse CMake for some unknown reason so for now
> > > > > >     remove libm from the Libs section, it's in the Libs.private so it's picked up
> > > > > >     just fine.
> > > > > >
> > > > > >     Fixes:  9e3878cf8428 ("graphics/wayland: Update to 1.24.0")
> > > > > >     Sponsored by:   Beckhoff Automation GmbH & Co. KG
> > > > >
> > > > > Do you plan to file a bug upstream? If you break API fixes cannot be upstreamed.
> > > >
> > > > I think this workaround should be reverted.
> > >
> > >  No.
> > >
> > > > If other ports fails with wayland-1.24, they should be fixed or
> > >
> > >  Those ports shouldn't fail with what was originally in wayland 1.24
> > > and shouldn't be patched.
> >
> > Emmanuel, could you provide an example port to reproduce the your problem, please?
> >
> > > > if outdated ninja-1.11 is the culprit, it should be updated.
> > >
> > >  Go ahead, I know nothing about ninja, I don't even know if that's the
> > > culprit but if it is then and only then I'll revert my hack.
> >
> > The hack is wrong, ports fail with it:
> >
> > https://cgit.freebsd.org/ports/commit/?id=f2d9466e25660bc430e3d092df9f9bb7f660ce84
> > https://cgit.freebsd.org/ports/commit/?id=a208f76c57a5ecb5723b9a0d95d6371b7ded507f
> > https://cgit.freebsd.org/ports/commit/?id=3e6a8fffef6d6b0318e7ee3cf8fe3dc09352c9cd
> >
> > while they build just fine without the wayland hack.
> >
> > Cheers,
> > Max
> >
> >
> 
> Emmanuel,
> 
> Max figured out that it was graphics/vulkan-tools that was failing in
> a discussion on #freebsd-desktop, but he is busy for a few days and
> asked the rest of the kde@ team to figure this out. From what I can
> tell, vulkan-tools upstream fixed this in [1]. The port builds fine
> with this change reverted and [1] applied.
> 
> I also think this commit should definitely be reverted and say we fix
> any other potentially broken ports with stock wayland since this
> commit seems to be breaking at least 3 other ports as cited above by
> Max. In the case of vulkan-tools, these were poor CMake constructs
> that just happened to work previously and are neither bugs with ninja
> nor with CMake.
> 
> [1] https://github.com/KhronosGroup/Vulkan-Tools/commit/105d6c1fede00c3a9055e5a531ebf3d99bac406e
> 
> - Jason

 Thanks for looking at this, I've reverted the wayland commit and
updated the vulkan-tools ports (and also reverted the now unneeded
commits that added -lm).

 Cheers,

-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>