From nobody Mon Aug 11 06:30:35 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c0lBb4lhzz64KHB; Mon, 11 Aug 2025 06:30:47 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4c0lBZ3lgXz3RJb; Mon, 11 Aug 2025 06:30:46 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; none Received: from skull.home.blih.net (mwc0868.ftth.cust.milkywan.net [45.13.107.196]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 566d7864 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 11 Aug 2025 06:30:38 +0000 (UTC) Date: Mon, 11 Aug 2025 08:30:35 +0200 From: Emmanuel Vadot To: "Jason E. Hale" Cc: Max Brazhnikov , Emmanuel Vadot , Jan Beich , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b991d37c58ed - main - graphics/wayland: Remove libm from pkgconfig Libs Message-Id: <20250811083035.406ace78466a7cbe66c50e24@bidouilliste.com> In-Reply-To: References: <202508060822.5768M6pK040832@gitrepo.freebsd.org> <2363855.mfXeX5GmMH@mercury> <20250809152154.90ffc1a3e54e5a1a7031e35a@bidouilliste.com> <2743956.TYJnH3iKXO@mercury> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd15.0) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4c0lBZ3lgXz3RJb X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR] On Mon, 11 Aug 2025 01:34:03 -0400 "Jason E. Hale" wrote: > On Sat, Aug 9, 2025 at 9:59?AM Max Brazhnikov wrote: > > > > On Sat, 9 Aug 2025 15:21:54 +0200 Emmanuel Vadot wrote: > > > On Sat, 09 Aug 2025 14:11:34 +0300 > > > Max Brazhnikov wrote: > > > > > > > On Fri, 08 Aug 2025 15:07:58 +0200 Jan Beich wrote: > > > > > Emmanuel Vadot writes: > > > > > > > > > > > This changes seems to confuse CMake for some unknown reason= so for now > > > > > > remove libm from the Libs section, it's in the Libs.private= so it's picked up > > > > > > just fine. > > > > > > > > > > > > Fixes: 9e3878cf8428 ("graphics/wayland: Update to 1.24.0") > > > > > > Sponsored by: Beckhoff Automation GmbH & Co. KG > > > > > > > > > > Do you plan to file a bug upstream? If you break API fixes cannot= be upstreamed. > > > > > > > > I think this workaround should be reverted. > > > > > > No. > > > > > > > If other ports fails with wayland-1.24, they should be fixed or > > > > > > Those ports shouldn't fail with what was originally in wayland 1.24 > > > and shouldn't be patched. > > > > Emmanuel, could you provide an example port to reproduce the your probl= em, please? > > > > > > if outdated ninja-1.11 is the culprit, it should be updated. > > > > > > Go ahead, I know nothing about ninja, I don't even know if that's the > > > culprit but if it is then and only then I'll revert my hack. > > > > The hack is wrong, ports fail with it: > > > > https://cgit.freebsd.org/ports/commit/?id=3Df2d9466e25660bc430e3d092df9= f9bb7f660ce84 > > https://cgit.freebsd.org/ports/commit/?id=3Da208f76c57a5ecb5723b9a0d95d= 6371b7ded507f > > https://cgit.freebsd.org/ports/commit/?id=3D3e6a8fffef6d6b0318e7ee3cf8f= e3dc09352c9cd > > > > while they build just fine without the wayland hack. > > > > Cheers, > > Max > > > > >=20 > Emmanuel, >=20 > Max figured out that it was graphics/vulkan-tools that was failing in > a discussion on #freebsd-desktop, but he is busy for a few days and > asked the rest of the kde@ team to figure this out. From what I can > tell, vulkan-tools upstream fixed this in [1]. The port builds fine > with this change reverted and [1] applied. >=20 > I also think this commit should definitely be reverted and say we fix > any other potentially broken ports with stock wayland since this > commit seems to be breaking at least 3 other ports as cited above by > Max. In the case of vulkan-tools, these were poor CMake constructs > that just happened to work previously and are neither bugs with ninja > nor with CMake. >=20 > [1] https://github.com/KhronosGroup/Vulkan-Tools/commit/105d6c1fede00c3a9= 055e5a531ebf3d99bac406e >=20 > - Jason Thanks for looking at this, I've reverted the wayland commit and updated the vulkan-tools ports (and also reverted the now unneeded commits that added -lm). Cheers, --=20 Emmanuel Vadot