Re: git: 21f77dd22253 - main - net/rsync: Update to 3.2.4

From: Rodrigo Osorio <rodrigo_at_osorio.me>
Date: Wed, 04 May 2022 09:59:47 UTC
On 5/4/22 08:16, Yasuhiro Kimura wrote:
> The branch main has been updated by yasu:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=21f77dd22253ffbe6a16b0367fda3f17c94848ac
>
> commit 21f77dd22253ffbe6a16b0367fda3f17c94848ac
> Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
> AuthorDate: 2022-04-19 11:27:39 +0000
> Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
> CommitDate: 2022-05-04 08:05:33 +0000
>
>      net/rsync: Update to 3.2.4
>      
>      * Pet portclippy
>      * Tidy up Makefile with portfmt
>      
>      ChangeLog:      https://download.samba.org/pub/rsync/NEWS#3.2.4
>      PR:             263417
>      Approved by:    maintainer timeout
> ---

Yasuhiro,

Sorry, but I still don't understanding your commit rush.
There is plenty of WIP in ports so why speeding up this one ?

Also, your commit message is incomplete:
You forgot to mention that rsync 3.2.4 introduces a security fix
for CVE-2018-25032.
You add an extra parameter for USE (python) without any mention.

You also silently remove io.c patch.
Hopefully the patch -which is required by FreeBSD infrastructure-
was merged by mainstream in this release but a few words about
that in the commit log will be appreciated.

Also, this version introduces behavior changes in rsync syntax,
an addition to CHANGES are always appreciated.

Regards,
-- rodrigo