From nobody Wed May 04 09:59:47 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6B6581AC796A; Wed, 4 May 2022 09:59:56 +0000 (UTC) (envelope-from rodrigo@osorio.me) Received: from smtp.osorio.me (mvd.osorio.me [5.196.94.126]) by mx1.freebsd.org (Postfix) with ESMTP id 4KtXPR2h8Wz4cH3; Wed, 4 May 2022 09:59:55 +0000 (UTC) (envelope-from rodrigo@osorio.me) Received: from [192.168.75.137] (ns3309494.ip-5-135-160.eu [5.135.160.30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.osorio.me (Postfix) with ESMTPSA id AB7E51623D7; Wed, 4 May 2022 09:59:46 +0000 (UTC) Message-ID: Date: Wed, 4 May 2022 11:59:47 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: git: 21f77dd22253 - main - net/rsync: Update to 3.2.4 Content-Language: en-US To: Yasuhiro Kimura , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202205040816.2448GTSI052306@gitrepo.freebsd.org> From: Rodrigo Osorio In-Reply-To: <202205040816.2448GTSI052306@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4KtXPR2h8Wz4cH3 X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of rodrigo@osorio.me has no SPF policy when checking 5.196.94.126) smtp.mailfrom=rodrigo@osorio.me X-Spamd-Result: default: False [1.29 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[rodrigo]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[osorio.me]; AUTH_NA(1.00)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_MEDIUM(0.96)[0.961]; NEURAL_SPAM_SHORT(0.33)[0.332]; MLMMJ_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main]; R_SPF_NA(0.00)[no SPF record]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:16276, ipnet:5.196.0.0/16, country:FR]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 5/4/22 08:16, Yasuhiro Kimura wrote: > The branch main has been updated by yasu: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=21f77dd22253ffbe6a16b0367fda3f17c94848ac > > commit 21f77dd22253ffbe6a16b0367fda3f17c94848ac > Author: Yasuhiro Kimura > AuthorDate: 2022-04-19 11:27:39 +0000 > Commit: Yasuhiro Kimura > CommitDate: 2022-05-04 08:05:33 +0000 > > net/rsync: Update to 3.2.4 > > * Pet portclippy > * Tidy up Makefile with portfmt > > ChangeLog: https://download.samba.org/pub/rsync/NEWS#3.2.4 > PR: 263417 > Approved by: maintainer timeout > --- Yasuhiro, Sorry, but I still don't understanding your commit rush. There is plenty of WIP in ports so why speeding up this one ? Also, your commit message is incomplete: You forgot to mention that rsync 3.2.4 introduces a security fix for CVE-2018-25032. You add an extra parameter for USE (python) without any mention. You also silently remove io.c patch. Hopefully the patch -which is required by FreeBSD infrastructure- was merged by mainstream in this release but a few words about that in the commit log will be appreciated. Also, this version introduces behavior changes in rsync syntax, an addition to CHANGES are always appreciated. Regards, -- rodrigo