Re: git: 973550dd663c - main - Revert "devel/wasi-compiler-rt14: add new port"

------- Original Message -------
On Sunday, July 17th, 2022 at 22:55, Stefan Eßer <se@FreeBSD.org> wrote:

>
>
> Am 17.07.22 um 19:54 schrieb Lorenzo Salvadore:> I think the commit below
>
> requires to add any entry to MOVED, as it actually
>
> > removed a port that existed, even if only for a short while and by mistake.
>
>
> I'd agree in general, but do not think so in this special case.
>
> The port had not been added to be built (despite having been built tested on
> amd64 an di386 on several FreeBSD releases), but only to allow "make index"
> to succeed on a system that defines LLVM_DEFAULT=14.
>
> There is no way a working firefox with WASI support could have been built
> with LLVM-14 at this time, since there are unresolved issues that still
> need to be fixed.
>
> And the firefox port has been changed to require LLVM-13 and the matching
> dependencies (like wasi-compiler-rt13).
>
> Even if this port has been installed on a system, I do not see how it could
> cause issue. If wasi-compiler-rt14 is committed again at a later time, it
> will have a higher minor version and any remains of the reverted port will
> just be replaced by an update to the new version.
>
>
> If you insist that a MOVED entry must still be created. this can of course
> be done. But I'll not feel responsible to remove it when WASI can be built
> with LLVM-14.

I don't insist as I don't know the ports infrastructure deeply enough to
understand if this case is special enough to avoid the MOVED entry, but I
encourage you to double check, in case there is some tool that expects to
find that line.

Cheers,

Lorenzo Salvadore