From nobody Sun Jul 17 21:50:09 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LmJfz4g5Pz4TDBB for ; Sun, 17 Jul 2022 21:50:19 +0000 (UTC) (envelope-from phascolarctos@protonmail.ch) Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "protonmail.com", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LmJfy2ysWz3Xdy; Sun, 17 Jul 2022 21:50:18 +0000 (UTC) (envelope-from phascolarctos@protonmail.ch) Date: Sun, 17 Jul 2022 21:50:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.ch; s=protonmail3; t=1658094616; x=1658353816; bh=XuOBsiEzreUvcZ83b+QQk9SDgMwkhYVTAJ/vc87ds7I=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=Sse2qxnYjUrhEFx+4jLOKPBMHkq02JOXpDBwALEnGN3sI5iftq/NfpXnfKeYKvB+2 JGMFQRfl/BryB5rwb+0bbsygKPdbH4s32rDX80heeRKkVB/iiPj3hCEQtSvrJ3jm4A fAyYOWEhLKKB/5TN/siWKprPy6Aaas7W5WaOx/ifyd+/puFErblFs2bdBkAs+MjxvV WxxzmZ/FxZTqx96jeFYXfMpHvySdwLKyaRzzQ11F2cZ4GWV91wSsOLDsNz+adPYu1x KUjgYo2EmQmpPXh0ieNbjbU0SJAtXCxn7M3zwhT3WT63jAfXFei4mfvzszHzcwb+wd qOOcHiC/eyorg== To: =?utf-8?Q?Stefan_E=C3=9Fer?= From: Lorenzo Salvadore Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Reply-To: Lorenzo Salvadore Subject: Re: git: 973550dd663c - main - Revert "devel/wasi-compiler-rt14: add new port" Message-ID: In-Reply-To: <4681c6a9-f10e-2cd8-0339-b480b1f52c01@FreeBSD.org> References: <202207171701.26HH10PP074399@gitrepo.freebsd.org> <4681c6a9-f10e-2cd8-0339-b480b1f52c01@FreeBSD.org> Feedback-ID: 8540510:user:proton List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4LmJfy2ysWz3Xdy X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=protonmail.ch header.s=protonmail3 header.b=Sse2qxnY; dmarc=pass (policy=quarantine) header.from=protonmail.ch; spf=pass (mx1.freebsd.org: domain of phascolarctos@protonmail.ch designates 185.70.43.22 as permitted sender) smtp.mailfrom=phascolarctos@protonmail.ch X-Spamd-Result: default: False [-3.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.996]; NEURAL_HAM_LONG(-0.98)[-0.983]; DMARC_POLICY_ALLOW(-0.50)[protonmail.ch,quarantine]; R_SPF_ALLOW(-0.20)[+ip4:185.70.43.0/24]; R_DKIM_ALLOW(-0.20)[protonmail.ch:s=protonmail3]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-ports-main@FreeBSD.org]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; MIME_TRACE(0.00)[0:+]; HAS_REPLYTO(0.00)[phascolarctos@protonmail.ch]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ASN(0.00)[asn:62371, ipnet:185.70.43.0/24, country:CH]; REPLYTO_EQ_FROM(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[protonmail.ch:+]; RCPT_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N ------- Original Message ------- On Sunday, July 17th, 2022 at 22:55, Stefan E=C3=9Fer wrot= e: > > > Am 17.07.22 um 19:54 schrieb Lorenzo Salvadore:> I think the commit below > > requires to add any entry to MOVED, as it actually > > > removed a port that existed, even if only for a short while and by mist= ake. > > > I'd agree in general, but do not think so in this special case. > > The port had not been added to be built (despite having been built tested= on > amd64 an di386 on several FreeBSD releases), but only to allow "make inde= x" > to succeed on a system that defines LLVM_DEFAULT=3D14. > > There is no way a working firefox with WASI support could have been built > with LLVM-14 at this time, since there are unresolved issues that still > need to be fixed. > > And the firefox port has been changed to require LLVM-13 and the matching > dependencies (like wasi-compiler-rt13). > > Even if this port has been installed on a system, I do not see how it cou= ld > cause issue. If wasi-compiler-rt14 is committed again at a later time, it > will have a higher minor version and any remains of the reverted port wil= l > just be replaced by an update to the new version. > > > If you insist that a MOVED entry must still be created. this can of cours= e > be done. But I'll not feel responsible to remove it when WASI can be buil= t > with LLVM-14. I don't insist as I don't know the ports infrastructure deeply enough to understand if this case is special enough to avoid the MOVED entry, but I encourage you to double check, in case there is some tool that expects to find that line. Cheers, Lorenzo Salvadore