Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0
Date: Wed, 28 Dec 2022 11:29:55 UTC
This was discussed in PR but not included in update: --- Old version have different values for USES: "compiler:gcc-c++11-lib" and "compiler:c++11-lang". New version have same value "compiler:c++14-lang" for both. So we can remove else in this if: =================================== .if !exists(/usr/include/omp.h) USES+= compiler:c++14-lang USE_GCC= yes .else USES+= compiler:c++14-lang .endif ----------------------------------- USES+= compiler:c++14-lang .if !exists(/usr/include/omp.h) USE_GCC= yes .endif =================================== --- Is: USES+= compiler:c++14-lang .if !exists(/usr/include/omp.h) USE_GCC= yes .endif the best and correct way to do it? Thanks Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia segunda, 26/12/2022 à(s) 22:30: > On 22-12-26 23:22:49, Gerald Pfeifer wrote: > >On Mon, 26 Dec 2022, Nuno Teixeira wrote: > >> .if !exists(/usr/include/omp.h) > >> -USES+= compiler:gcc-c++11-lib > >> +USES+= compiler:c++14-lang > >> +USE_GCC= yes > >> .else > >> -USES+= compiler:c++11-lang > >> +USES+= compiler:c++14-lang > >> .endif > > > >This sets > > USES+= compiler:c++14-lang > >in both the if-arm and the else-arm. > > > >Why not set this unconditionally then? > > > >And combining compiler:c++14-lang and USE_GCC=yes is odd; I don't think > >that really works. > > > >Are you sure this entire block is still necessary at all? Where would it > >make a difference? > > > >Gerald > > Gerald is right. > > Moreover, USE_GCC=yes forces linking on libstdc++ which might cause > runtime issues. > -- Nuno Teixeira FreeBSD Committer (ports)