From nobody Wed Dec 28 11:29:55 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nhq7g6mHLz1HwVy; Wed, 28 Dec 2022 11:30:07 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nhq7g6G0Yz4L5m; Wed, 28 Dec 2022 11:30:07 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672227007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HRw6ABH+78IgG06+T7ITWlRH+oQuhVM1JUIJR8TUCLA=; b=ShdvQGfeeFVKhis+HrtVkNRpojZBmLCpBy8HdpboB+adkNM9JWktoVkeKd5AzdKKc/TGqw PEjCYBbJJ0yJ83BaWC7BBGmui3XfTTRgY7VHRV+/rhNvM7wi00EQL+tgGNXXGmidqtBlLQ iFtOtEcsHJ9EQcInLqBU9Sv+PbUylYIC7W2TM3Io3Umng30HSA1QQbLTnee7lWkdjTGTS6 CvjivghcHdzsHlx9LeEZcahL5E2q8KMv5Lomzg2kPtngisqE6p3dVj8i4q/dpjC9ZMbarZ 7vto9CFGg3FF9zq3WRDb64DuwT0vtNkAOMAhcGkOzJcNjBCOu+3jW971BdkYfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672227007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HRw6ABH+78IgG06+T7ITWlRH+oQuhVM1JUIJR8TUCLA=; b=d6U1VBVmnOV3MrkRmXXsn8Zs02Shb+rrnt36lDS7VzQn4P8hgHec6eDo1bAW9WPBWVbgj9 do0emHwc90jIp8Tc0pGWQfilAoSFJ3LvecL5RTofUTwRnclsBCpoB+B4VjgyQUxBdllTD9 7zOO+6sgCjo9JAyOGDm3rrdK5ip8Q+8GRsOBq7ipdIJ4GlxrFKHOTxTeGwdYLjNuH5ZzZ3 ytIGFIRe2GZ7rmHsD6hT4H21tIyB+tWA4z7+aZMp+joltvqWMpAYLbqbRBmybsuCDFs7ds vH3Woxq5xRK0FOslqtBpO0nDErv6Zyp95SseiqRPClyFuSLy1LLL5KsUMhCziw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1672227007; a=rsa-sha256; cv=none; b=UsNCqWKk5mtBMyI5QWvdtE9SfBbKTTOfn9/XqBbYMJRvzjW3abjuTDSlJhfWeY0qdZFUAL NT73b5v3FCJ14N6kHL5HRpecYYkdPqzndp5949bVz7h/IhUW/YiHhjVU7UE1DT67TjUY57 KAGtk01U3p6IWC0dJyBQVqyhuhk9hqSavyugM+fyxOFPDBpNXX20nlVtM0yadPtDCxQlTc UYUcyOB+QyXjDPVkK286oFL1f80blIzKKgJEi59OCdNN0ahSLAnNhSjyBk0cU1SL3+9/78 FPIQfNySdHq0dALqgL4FYbJaCornmDdIsGyXDXNMZ52vxyN14GdIKklumuAvBw== Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Nhq7g5BBDzPFF; Wed, 28 Dec 2022 11:30:07 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-vs1-f50.google.com with SMTP id a64so11723086vsc.2; Wed, 28 Dec 2022 03:30:07 -0800 (PST) X-Gm-Message-State: AFqh2kpT2Ck0Zfetcx3UqeMGksyafFF+d5Pr6p/zjUI6LGpUYE/iKLZB dkHvrZEQ8sbu90EPrgBzqo2KafZ0b0Aalcv7kAY= X-Google-Smtp-Source: AMrXdXuFOGWvwepl7DIuoJ6QhLKg0NfPmYLY3g3K7y+STHYOj5znSIw6FO0Y3mhUNzyA/BYbi5aA6nV+jCxQsUMsW0w= X-Received: by 2002:a67:e958:0:b0:3b1:502b:fe23 with SMTP id p24-20020a67e958000000b003b1502bfe23mr3485124vso.19.1672227006869; Wed, 28 Dec 2022 03:30:06 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202212260526.2BQ5QNkY028999@gitrepo.freebsd.org> <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> In-Reply-To: From: Nuno Teixeira Date: Wed, 28 Dec 2022 11:29:55 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 To: Piotr Kubaj Cc: Gerald Pfeifer , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000ba763205f0e1b06d" X-ThisMailContainsUnwantedMimeParts: N --000000000000ba763205f0e1b06d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This was discussed in PR but not included in update: --- Old version have different values for USES: "compiler:gcc-c++11-lib" and "compiler:c++11-lang". New version have same value "compiler:c++14-lang" for both. So we can remove else in this if: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D .if !exists(/usr/include/omp.h) USES+=3D compiler:c++14-lang USE_GCC=3D yes .else USES+=3D compiler:c++14-lang .endif ----------------------------------- USES+=3D compiler:c++14-lang .if !exists(/usr/include/omp.h) USE_GCC=3D yes .endif =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- Is: USES+=3D compiler:c++14-lang .if !exists(/usr/include/omp.h) USE_GCC=3D yes .endif the best and correct way to do it? Thanks Piotr Kubaj escreveu no dia segunda, 26/12/2022 =C3=A0= (s) 22:30: > On 22-12-26 23:22:49, Gerald Pfeifer wrote: > >On Mon, 26 Dec 2022, Nuno Teixeira wrote: > >> .if !exists(/usr/include/omp.h) > >> -USES+=3D compiler:gcc-c++11-lib > >> +USES+=3D compiler:c++14-lang > >> +USE_GCC=3D yes > >> .else > >> -USES+=3D compiler:c++11-lang > >> +USES+=3D compiler:c++14-lang > >> .endif > > > >This sets > > USES+=3D compiler:c++14-lang > >in both the if-arm and the else-arm. > > > >Why not set this unconditionally then? > > > >And combining compiler:c++14-lang and USE_GCC=3Dyes is odd; I don't thin= k > >that really works. > > > >Are you sure this entire block is still necessary at all? Where would it > >make a difference? > > > >Gerald > > Gerald is right. > > Moreover, USE_GCC=3Dyes forces linking on libstdc++ which might cause > runtime issues. > --=20 Nuno Teixeira FreeBSD Committer (ports) --000000000000ba763205f0e1b06d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This was discussed in PR but not included in update:
--= -
Old version have different values for USES: "compiler:gcc-c++11-l= ib" and "compiler:c++11-lang".
New version have same valu= e "compiler:c++14-lang" for both.
So we can remove else in thi= s if:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
.if !exists(/usr/include/omp.h)<= br>USES+=3D compiler:c++14-lang
USE_GCC=3D yes
.else
USES+=3D comp= iler:c++14-lang
.endif
-----------------------------------
USES+= =3D compiler:c++14-lang
.if !exists(/usr/include/omp.h)
USE_GCC=3D y= es
.endif
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
---

Is:
USES+=3D compiler:c++14-lang
.if !exists(= /usr/include/omp.h)
USE_GCC=3D yes
.endif

th= e best and correct way to do it?

Thanks
<= div>



Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia segunda, = 26/12/2022 =C3=A0(s) 22:30:
On 22-12-26 23:22:49, Gerald Pfeifer wrote:
>On Mon, 26 Dec 2022, Nuno Teixeira wrote:
>>=C2=A0 .if !exists(/usr/include/omp.h)
>> -USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler= :gcc-c++11-lib
>> +USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler= :c++14-lang
>> +USE_GCC=3D=C2=A0 =C2=A0 yes
>>=C2=A0 .else
>> -USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler= :c++11-lang
>> +USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler= :c++14-lang
>>=C2=A0 .endif
>
>This sets
>=C2=A0 USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0c= ompiler:c++14-lang
>in both the if-arm and the else-arm.
>
>Why not set this unconditionally then?
>
>And combining compiler:c++14-lang and USE_GCC=3Dyes is odd; I don't= think
>that really works.
>
>Are you sure this entire block is still necessary at all? Where would i= t
>make a difference?
>
>Gerald

Gerald is right.

Moreover, USE_GCC=3Dyes forces linking on libstdc++ which might cause
runtime issues.


--
Nun= o Teixeira
FreeBSD Committer (ports)
--000000000000ba763205f0e1b06d--