Re: git: 2cfc957feca9 - main - audio/faac: revert undue port deprecation

On 2025-04-30 08:37, Alexey Dokuchaev wrote:
> The branch main has been updated by danfe:
>
> URL:https://cgit.FreeBSD.org/ports/commit/?id=2cfc957feca9ba1994bb7adc994a2787c9f9e92c
>
> commit 2cfc957feca9ba1994bb7adc994a2787c9f9e92c
> Author:     Alexey Dokuchaev<danfe@FreeBSD.org>
> AuthorDate: 2025-04-30 06:36:20 +0000
> Commit:     Alexey Dokuchaev<danfe@FreeBSD.org>
> CommitDate: 2025-04-30 06:36:20 +0000
>
>      audio/faac: revert undue port deprecation
>      
>      - It's being used by the `audio/flacon' port, both as part of the
>        test suite and optional user-facing run-time dependency
>      - Upstream is active and any complaints regarding the code itself
>        should be sent there rather than used as a deprecation reason
> ---
>   audio/faac/Makefile | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/audio/faac/Makefile b/audio/faac/Makefile
> index cdf113b4bec5..0d5fff485e20 100644
> --- a/audio/faac/Makefile
> +++ b/audio/faac/Makefile
> @@ -13,9 +13,6 @@ LICENSE_NAME_ISO=	ISO/IEC14496
>   LICENSE_FILE_ISO=	${WRKSRC}/README
>   LICENSE_PERMS_ISO=	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept
>   
> -DEPRECATED=	Produces poor audio quality compared to other encoders, consider using audio/fdk-aac , audio/exhale (xHE-AAC which supersedes AAC-LC) or FFmpeg's native encoder
> -EXPIRATION_DATE=2025-04-30
> -
>   USES=		autoreconf compiler:c11 gmake libtool pathfix
>   USE_LDCONFIG=	yes
>   

Hi,

This is a clear violation of 
https://docs.freebsd.org/en/articles/committers-guide/#rules

This was announced both using bugzilla and via the mailing lists almost 
2 months ago, which you failed to give any input on within any 
reasonable time and these last minute commits are questionable in many 
regards and not how we should operate.

This just burns cycles we can spend elsewhere and it's a runtime 
dependency, even so many distros don't install it with flacon and only 
lists it as optional.

Upstream also suggests that you can use a wrapper script to fix this 
which we certainly can work on.

https://github.com/flacon/flacon/issues/57#issuecomment-355753455

Best regards,

Daniel