From nobody Thu May 01 10:57:11 2025 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zp9x65khtz5v0j3; Thu, 01 May 2025 10:57:14 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zp9x64jYyz44CY; Thu, 01 May 2025 10:57:14 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746097034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JIT72FGH398Y4seRELY3IS7x97S74r+EuZQu4fvwDYc=; b=knDr44fFJIRdaukIjJJYugR1RdQmAb2LLDJUXiEzdG8R/W7irfPWZS9VXS7pk7gbpvAKJa rkcCzfu6TKVojyQFbEcGnz/5CkdTRjc2ILBdYc2rw/gBwH+kUhHNoH6/VU/uzyKZbCjULX Mj2GAj8J1a28jh+DtDIcnIByo0/vSJZtcMnJffzoDR2WxDldkoPgxYelqIAO1nSdN82E5E Hv7+Sg08xIC9NOu8g8ZCL8GTsQZergYuz7T2tHtBs/zMAVYw9RSaP5xUEIpptn/MSxYOKJ A+Ny1MbQJ0IPPsoR8MkQ4n1Ba4VbVdHul3WB2buNJ3pfLOV4YtPUIZn4j27y2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746097034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JIT72FGH398Y4seRELY3IS7x97S74r+EuZQu4fvwDYc=; b=G5B+e3tARF1p75NlxJ9d7D0T80/5BeO8qyJGS1hsa0qsCk5Ys7mha1EroiRi/vr44C5mIG vo6FTwDXRtDERYiMSA8ID9rzlQOHTJbKwmVgYtJ4i8E3fr3ivIjSnZS/jFlW1ux9xHaisQ RRGzwPnzFIXmlYWzY3Mtm3tn1G9xtFI0zSOkK82T/jGYy3jI8VXI+6++QdjtS12u/EFO0R 6x7v4jq0icp3UIGZ7lpGYipUk6YRCNK/xTKagkFyCkkURDj8vVYVgLfZOFhhtaCA5mhWu0 9veIE4MYba095pc0ttaeIKS7wsbrb8xstxVWeVk9quYqKG705o1jk14RUp7cQw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746097034; a=rsa-sha256; cv=none; b=gK88L35Dqs4xmAL/Npe/XDPukxrnJVr1fWpSIYkol1sx/Eubhqx/myVTYDz34H5lTaQIjb K9C9/OpAallg078lwSsh4FvD5IYbzA+ZQKxcV8EzvcRYwFcU0yNEh2ZSTJ9i0kPS4jT6lN teAD3VW1nqhndMmGgAkbUytD8SBZc9uveg7hjekDBgQpr2TpFJ9+lkyHRW949Oubc9Sudp 6DyWESVdI7umkmoQCRV4UtG46ef14Boyy07Y7BlJK7G/4U29PKXVxzih23Q7TBI231uyz/ z04P3SwX0NpsgHpvlTTywAgaqCFBEfNsO5EntYGDN7yw6Lwukw0sOziNmh75DA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [192.168.1.16] (217-209-194-237-no600.tbcn.telia.com [217.209.194.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: diizzy/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Zp9x56GWSz6bm; Thu, 01 May 2025 10:57:13 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Content-Type: multipart/alternative; boundary="------------l0oWpqpAP8k4LPP0GV1cVt7j" Message-ID: <21abc636-609d-48ad-845f-30ff9aaa82f2@FreeBSD.org> Date: Thu, 1 May 2025 12:57:11 +0200 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: git: 2cfc957feca9 - main - audio/faac: revert undue port deprecation To: Alexey Dokuchaev , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org, FreeBSD Ports Management Team References: <202504300637.53U6bsST079894@gitrepo.freebsd.org> Content-Language: en-US From: Daniel Engberg In-Reply-To: <202504300637.53U6bsST079894@gitrepo.freebsd.org> This is a multi-part message in MIME format. --------------l0oWpqpAP8k4LPP0GV1cVt7j Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2025-04-30 08:37, Alexey Dokuchaev wrote: > The branch main has been updated by danfe: > > URL:https://cgit.FreeBSD.org/ports/commit/?id=2cfc957feca9ba1994bb7adc994a2787c9f9e92c > > commit 2cfc957feca9ba1994bb7adc994a2787c9f9e92c > Author: Alexey Dokuchaev > AuthorDate: 2025-04-30 06:36:20 +0000 > Commit: Alexey Dokuchaev > CommitDate: 2025-04-30 06:36:20 +0000 > > audio/faac: revert undue port deprecation > > - It's being used by the `audio/flacon' port, both as part of the > test suite and optional user-facing run-time dependency > - Upstream is active and any complaints regarding the code itself > should be sent there rather than used as a deprecation reason > --- > audio/faac/Makefile | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/audio/faac/Makefile b/audio/faac/Makefile > index cdf113b4bec5..0d5fff485e20 100644 > --- a/audio/faac/Makefile > +++ b/audio/faac/Makefile > @@ -13,9 +13,6 @@ LICENSE_NAME_ISO= ISO/IEC14496 > LICENSE_FILE_ISO= ${WRKSRC}/README > LICENSE_PERMS_ISO= dist-mirror dist-sell pkg-mirror pkg-sell auto-accept > > -DEPRECATED= Produces poor audio quality compared to other encoders, consider using audio/fdk-aac , audio/exhale (xHE-AAC which supersedes AAC-LC) or FFmpeg's native encoder > -EXPIRATION_DATE=2025-04-30 > - > USES= autoreconf compiler:c11 gmake libtool pathfix > USE_LDCONFIG= yes > Hi, This is a clear violation of https://docs.freebsd.org/en/articles/committers-guide/#rules This was announced both using bugzilla and via the mailing lists almost 2 months ago, which you failed to give any input on within any reasonable time and these last minute commits are questionable in many regards and not how we should operate. This just burns cycles we can spend elsewhere and it's a runtime dependency, even so many distros don't install it with flacon and only lists it as optional. Upstream also suggests that you can use a wrapper script to fix this which we certainly can work on. https://github.com/flacon/flacon/issues/57#issuecomment-355753455 Best regards, Daniel --------------l0oWpqpAP8k4LPP0GV1cVt7j Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
On 2025-04-30 08:37, Alexey Dokuchaev wrote:
The branch main has been updated by danfe:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2cfc957feca9ba1994bb7adc994a2787c9f9e92c

commit 2cfc957feca9ba1994bb7adc994a2787c9f9e92c
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2025-04-30 06:36:20 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2025-04-30 06:36:20 +0000

    audio/faac: revert undue port deprecation
    
    - It's being used by the `audio/flacon' port, both as part of the
      test suite and optional user-facing run-time dependency
    - Upstream is active and any complaints regarding the code itself
      should be sent there rather than used as a deprecation reason
---
 audio/faac/Makefile | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/audio/faac/Makefile b/audio/faac/Makefile
index cdf113b4bec5..0d5fff485e20 100644
--- a/audio/faac/Makefile
+++ b/audio/faac/Makefile
@@ -13,9 +13,6 @@ LICENSE_NAME_ISO=	ISO/IEC14496
 LICENSE_FILE_ISO=	${WRKSRC}/README
 LICENSE_PERMS_ISO=	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept
 
-DEPRECATED=	Produces poor audio quality compared to other encoders, consider using audio/fdk-aac , audio/exhale (xHE-AAC which supersedes AAC-LC) or FFmpeg's native encoder
-EXPIRATION_DATE=2025-04-30
-
 USES=		autoreconf compiler:c11 gmake libtool pathfix
 USE_LDCONFIG=	yes

Hi,

This is a clear violation of https://docs.freebsd.org/en/articles/committers-guide/#rules

This was announced both using bugzilla and via the mailing lists almost 2 months ago, which you failed to give any input on within any reasonable time and these last minute commits are questionable in many regards and not how we should operate.

This just burns cycles we can spend elsewhere and it's a runtime dependency, even so many distros don't install it with flacon and only lists it as optional.

Upstream also suggests that you can use a wrapper script to fix this which we certainly can work on.

https://github.com/flacon/flacon/issues/57#issuecomment-355753455

Best regards,

Daniel

--------------l0oWpqpAP8k4LPP0GV1cVt7j--