Re: git: 00a03a0a6d82 - main - misc/R-cran-xfun: Update to 0.51
- In reply to: Nuno Teixeira : "Re: git: 00a03a0a6d82 - main - misc/R-cran-xfun: Update to 0.51"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 21 Feb 2025 20:52:46 UTC
On Fri, Feb 21, 2025 at 02:50:07PM +0000, Nuno Teixeira wrote:
> Thats a very nice idea!
>
> That way, WWW could be set to CRAN or custom URL choosed by maintainer.
>
> As an example, we have devel/R-cran-lintr:
>
> WWW= https://github.com/r-lib/lintr (custom URL)
> or opt for
> WWW=CRAN (default canonical form)
I think doesn't need a new "variable" (CRAN). As I see the pear.mk does
similar:
WWW?=https://pear.php.net/package/${PORTNAME}/
( https://cgit.freebsd.org/ports/tree/Mk/Uses/pear.mk#n43 )
So in this case if maintainer doesn't set WWW in port's Makefile will
be the default.
Another thing in cran.mk:
https://cgit.freebsd.org/ports/tree/Mk/Uses/cran.mk#n33
Checks the existence of bin/pdflatex and if it false add plus option to
checking. It's bad as Porter's handbook suggests. Should be a parameter
(eg. test-vignettes in cran_ARGS) and if it set automatically add texlive-bin to
TEST_DEPENDS.
Another else: in do-test target use MAKE_ENV - it's confusing because
Porter's Handbook says the TEST_ENV is the proper variable
(see https://docs.freebsd.org/en/books/porters-handbook/book/#make-test).
So if a porter doesn't check cran.mk set the TEST_ENV and it isn't used
in do-test.
Cheers,
Zsolt