From nobody Fri Feb 21 20:52:46 2025 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z02Qc46K0z5pKX5; Fri, 21 Feb 2025 20:53:12 +0000 (UTC) (envelope-from uzsolt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z02Qc3GB2z4PS1; Fri, 21 Feb 2025 20:53:12 +0000 (UTC) (envelope-from uzsolt@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740171192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IZJfzFbojDdoqJP6EVemdO6X7kQF4RRKtH5PMDIxa74=; b=A/9ihLVhmDaZ502K4vkfOVWLcRbTlV9R5qTgGHmA1kiGvEPdQ/Ti28VX9QlIGHsLK48RUQ 9ctUR+4hvUg250F8tN7TZ0jBYxEwrQrPnNiQPc1iS9djbA7yfKhmL+NOrQ3XvblLkWclyx 0zVI4MpRZ83pgQWlqTQH5rBO3rICVsIF/kKuIPWLow81+GnrSlV8xtOkGood6DP/KOMw2n mNF4uU1d8r/iC483QNMk4MDhcn5au4ekwX4p6O+BZyhyWLrhYNVeWJxE/GsgiEeGr6bA/W VINvm7gRmc/ze0NrRXuR9Z+s7oXnoXuZLyBHqlpV7o2lvTjkkz6TOuV6djFDgQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740171192; a=rsa-sha256; cv=none; b=fDjr0z2r5v2AwwgbAR78s7TzlIHVS76qBNz8MgJ4whbWo513/GCNi9IqYJqjeXn5pfGrcX CoW8hBCJIpJx3kue0g59FFGYX4PaUZdOFOjc3qLmbPNLji47QAKPLgMkFigxanWcMeL4jg /IgpT/pvMTS+U21AMymL3I2hsutr31z+fmck/Sj2guSnJSf9TmcEUDZ8RM6oM0FGU67HIb 5+yKvzxQULC9w5BA7PvPIbmVmrkXvAQvKeYewa77RrE8f4h21EiIcctqNKIDoc83g91XO/ NPDpGiEnT4NshqVeLy3QJp1p4jyDaiW8y996bjPlaG15SiFlWh/u5V/hXQsVIw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740171192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IZJfzFbojDdoqJP6EVemdO6X7kQF4RRKtH5PMDIxa74=; b=caDf0NOxmL1Iirx/hzo5MkHJGr3Mz0dSpYCx5pe2PCGGG5uHOovjU/BsCqmmJTIE2PYCsM PJP7qu/1tjFRceHpvXWejvK2IOjziNe28Xw7199iF6TCCOdC+VbXMcDKOMO+SU/ZO6h4wo ZmW9ogWOxTRl/Ra2gUihSpuBNnVhsVKrRSsWh5nSxG84hNigrkO7je4RdtYhz5Aok8ADSa STgV6twIJqOfKY1wL7PFXAt7M1Maul68p4MDwO6w59KYSlwnmAhYJ4a6GB/vf5yO6tlMof VnGK4SLcylBDTkn9N36jKawcY8V93JOMZxNhdde2jnnZSXjGQ7eCLW8dln269A== Received: from bsd-zsolt (91-82-30-64.pool.digikabel.hu [91.82.30.64]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: uzsolt/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Z02Qb4dSmzLFh; Fri, 21 Feb 2025 20:53:11 +0000 (UTC) (envelope-from uzsolt@freebsd.org) Date: Fri, 21 Feb 2025 21:52:46 +0100 From: Zsolt Udvari To: Nuno Teixeira Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 00a03a0a6d82 - main - misc/R-cran-xfun: Update to 0.51 Message-ID: References: <202502211158.51LBwT5J091197@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Feb 21, 2025 at 02:50:07PM +0000, Nuno Teixeira wrote: > Thats a very nice idea! > > That way, WWW could be set to CRAN or custom URL choosed by maintainer. > > As an example, we have devel/R-cran-lintr: > > WWW= https://github.com/r-lib/lintr (custom URL) > or opt for > WWW=CRAN (default canonical form) I think doesn't need a new "variable" (CRAN). As I see the pear.mk does similar: WWW?=https://pear.php.net/package/${PORTNAME}/ ( https://cgit.freebsd.org/ports/tree/Mk/Uses/pear.mk#n43 ) So in this case if maintainer doesn't set WWW in port's Makefile will be the default. Another thing in cran.mk: https://cgit.freebsd.org/ports/tree/Mk/Uses/cran.mk#n33 Checks the existence of bin/pdflatex and if it false add plus option to checking. It's bad as Porter's handbook suggests. Should be a parameter (eg. test-vignettes in cran_ARGS) and if it set automatically add texlive-bin to TEST_DEPENDS. Another else: in do-test target use MAKE_ENV - it's confusing because Porter's Handbook says the TEST_ENV is the proper variable (see https://docs.freebsd.org/en/books/porters-handbook/book/#make-test). So if a porter doesn't check cran.mk set the TEST_ENV and it isn't used in do-test. Cheers, Zsolt