Re: git: a77030fc2ead - main - graphics/exiv2: Update to 0.28.4

On 2025-02-13 13:56, Jason E. Hale wrote:
> The branch main has been updated by jhale:
>
> URL:https://cgit.FreeBSD.org/ports/commit/?id=a77030fc2ead68b333afa5ab4f283de1ed78da1c
>
> commit a77030fc2ead68b333afa5ab4f283de1ed78da1c
> Author:     Jason E. Hale<jhale@FreeBSD.org>
> AuthorDate: 2025-02-13 12:48:41 +0000
> Commit:     Jason E. Hale<jhale@FreeBSD.org>
> CommitDate: 2025-02-13 12:56:11 +0000
>
>      graphics/exiv2: Update to 0.28.4
>      
>      Pet portclippy(1) a bit.
>      
>      Automate shared library version updates in pkg-plist.
>      
>      https://github.com/Exiv2/exiv2/releases/tag/v0.28.4
> ---
>   graphics/exiv2/Makefile  | 14 ++++++++++----
>   graphics/exiv2/distinfo  |  6 +++---
>   graphics/exiv2/pkg-plist |  4 ++--
>   3 files changed, 15 insertions(+), 9 deletions(-)
>
> diff --git a/graphics/exiv2/Makefile b/graphics/exiv2/Makefile
> index e3399ce4731d..deff9e1cdfde 100644
> --- a/graphics/exiv2/Makefile
> +++ b/graphics/exiv2/Makefile
> @@ -1,6 +1,6 @@
>   PORTNAME=	exiv2
>   DISTVERSIONPREFIX=	v
> -DISTVERSION=	0.28.3
> +DISTVERSION=	0.28.4
>   PORTEPOCH=	1
>   CATEGORIES=	graphics
>   
> @@ -17,19 +17,25 @@ LIB_DEPENDS=	libbrotlidec.so:archivers/brotli \
>   
>   USES=		cmake compiler:c++17-lang cpe dos2unix gettext-tools iconv \
>   		localbase:ldflags pathfix shebangfix
> -DOS2UNIX_FILES=	cmake/compilerFlags.cmake
> -SHEBANG_FILES=	fuzz/mkdictionary.py tests/runner.py
>   USE_LDCONFIG=	yes
>   
>   USE_GITHUB=	yes
>   GH_ACCOUNT=	Exiv2
>   
> +DOS2UNIX_FILES=	cmake/compilerFlags.cmake
> +
> +SHEBANG_FILES=	fuzz/mkdictionary.py \
> +		tests/runner.py
> +
>   CMAKE_ON=	EXIV2_ENABLE_VIDEO
>   CMAKE_OFF=	EXIV2_ENABLE_EXTERNAL_XMP
>   
>   LDFLAGS_mips=	-lintl
>   LDFLAGS_mips64=	-lintl
>   
> +PLIST_SUB=	SOVER=${DISTVERSION:R:E} \
> +		SOVERSION=${DISTVERSION}
> +
>   OPTIONS_DEFINE=	DOCS DOXYGEN NLS SAMPLE TEST
>   OPTIONS_SUB=	yes
>   
> @@ -46,12 +52,12 @@ NLS_CMAKE_BOOL=	EXIV2_ENABLE_NLS
>   
>   SAMPLE_CMAKE_BOOL=	EXIV2_BUILD_SAMPLES
>   
> +TEST_IMPLIES=		SAMPLE
>   TEST_BUILD_DEPENDS=	googletest>0:devel/googletest
>   TEST_TEST_DEPENDS=	bash:shells/bash
>   TEST_USES=		python:build,test
>   TEST_CMAKE_BOOL=	EXIV2_BUILD_UNIT_TESTS
>   TEST_CMAKE_ON=		-DPython${PYTHON_MAJOR_VER}_EXECUTABLE:FILEPATH="${PYTHON_CMD}"
>   TEST_TEST_TARGET=	test
> -TEST_IMPLIES=		SAMPLE
>   
>   .include <bsd.port.mk>
> diff --git a/graphics/exiv2/distinfo b/graphics/exiv2/distinfo
> index cd05244fa7e7..051be07df099 100644
> --- a/graphics/exiv2/distinfo
> +++ b/graphics/exiv2/distinfo
> @@ -1,3 +1,3 @@
> -TIMESTAMP = 1725693241
> -SHA256 (Exiv2-exiv2-v0.28.3_GH0.tar.gz) = 1315e17d454bf4da3cc0edb857b1d2c143670f3485b537d0f946d9ed31d87b70
> -SIZE (Exiv2-exiv2-v0.28.3_GH0.tar.gz) = 46480702
> +TIMESTAMP = 1739446777
> +SHA256 (Exiv2-exiv2-v0.28.4_GH0.tar.gz) = 65cb3a813f34fb6db7a72bba3fc295dd6c419082d2d8bbf96518be6d1024b784
> +SIZE (Exiv2-exiv2-v0.28.4_GH0.tar.gz) = 46932087
> diff --git a/graphics/exiv2/pkg-plist b/graphics/exiv2/pkg-plist
> index 1e0a93bda246..00e7fef49d17 100644
> --- a/graphics/exiv2/pkg-plist
> +++ b/graphics/exiv2/pkg-plist
> @@ -66,8 +66,8 @@ lib/cmake/exiv2/exiv2ConfigVersion.cmake
>   lib/cmake/exiv2/exiv2Export-%%CMAKE_BUILD_TYPE%%.cmake
>   lib/cmake/exiv2/exiv2Export.cmake
>   lib/libexiv2.so
> -lib/libexiv2.so.0.28.3
> -lib/libexiv2.so.28
> +lib/libexiv2.so.%%SOVERSION%%
> +lib/libexiv2.so.%%SOVER%%
>   libdata/pkgconfig/exiv2.pc
>   %%NLS%%share/locale/bs/LC_MESSAGES/exiv2.mo
>   %%NLS%%share/locale/ca/LC_MESSAGES/exiv2.mo

Hi,

Please review what portclippy actually suggests as this is not syntax 
Porters Handbook states (and some suggestions are bad at best). Please 
revert layout changes.

https://docs.freebsd.org/en/books/porters-handbook/book/#uses-shebangfix

https://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-automatic-replacements

Best regards,

Daniel