From nobody Thu Feb 13 21:26:39 2025 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yv7Xy6hPSz5nJn1; Thu, 13 Feb 2025 21:26:42 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yv7Xy67Shz42Sg; Thu, 13 Feb 2025 21:26:42 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739482002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KFm7U5juJQ91i1bHfeq5pBwox0SWXtkKRwrzaYrkADc=; b=vUEOuCNg8UUFG0i6989DEn7q/7cX/yYrGYjBRsN6xPpEgBI2Z3+ekGSnI2km0FCeKNA/NU LcuDaRlgCe27jbQwaITCWg1auFjhI0Xd7PH1CI+xeB8D9Ek477o0hyobS3bYdCjirQ04IH C86aPFVf/p7fVCRfWYtNucB/hJwtSVtQg7CU5xl2FYY6B3i7OvW5gzr/ume4ialod4NFGP PqlIMZhKLByKN+I9zILB019UMMJfmsEgGpQ+USja/WwNb7jTXJPWmd+NddIrS2nIcikB0Y x6wsY+MEcasSR4sp53MWDs23Rx+Oy0XOnfflro6/MwOgSrK9sVPtevR4YHntVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739482002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KFm7U5juJQ91i1bHfeq5pBwox0SWXtkKRwrzaYrkADc=; b=Wh5IYLseDPjEPLKdhHq4/C4FMU9vmX92drIlO07iD42pVMdKMyw9R89laOPO9PmvPgDa1O 5DlndsB8KneyIVV0++L1IvyOF6cRBUgKzjbKPhM/CJ63fgCM0uJH7LeXPmGTZFo5KcSHgI IzaoE5kgTIpIp9bBcSOocDSYREigIaOkxfwblKGNBmFYX64TVPQdZu0S8kfrz3EYjGYZhw QPHk1aiBZEEx3waE9jyY/aiW2JY6ZTD42PDhcN1ezSZMSix2On4mrlOBHqkWaDnwavALn1 dOpTxUuAksEngZTRvYxZfR48SyQS/dqyT2uLDGWeyLYq+EyzRnzu/3QHFFr8ZQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1739482002; a=rsa-sha256; cv=none; b=yyrzODIjR6VsxYCeN0qrssfyT7KdcivSyR8qFKgSKXQCVrXu7vLNbBebYECkXYVgSUAGgR /0F93bxF+ZoABIGLrJmWDRAR93mtYTIIZX0zTfc+94fFSSWBeNRsQiTp84/A3lHSbpDYKc DzcBrTLqcovtDH/Pv0fwKVTeELv5O8kFcDF1boI8qFS1Btg/qxcI7iuB7DXnoMOCAoM3W3 0OYAlOlN5CrUKUoqRq7eLbg4CqnpkO/SK9mqMHJYR5W0f9jSrrgooeClV4tj0LssN5XbgB rcHX6iaV3+1xhgsroD9gZKiDmAtmhWrvzmLan4gZ2vgBEKxhTOOUEp/HFySo+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [192.168.1.238] (90-229-134-185-no600.tbcn.telia.com [90.229.134.185]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: diizzy/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Yv7Xy1X0zz30f; Thu, 13 Feb 2025 21:26:42 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Content-Type: multipart/alternative; boundary="------------v1ed3z0SrQXG7wvPYBffAVjt" Message-ID: <1e98cdc3-1656-4b80-af9b-0a0d4d29c8ef@FreeBSD.org> Date: Thu, 13 Feb 2025 22:26:39 +0100 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: git: a77030fc2ead - main - graphics/exiv2: Update to 0.28.4 To: "Jason E. Hale" , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202502131256.51DCuHsw011380@gitrepo.freebsd.org> Content-Language: en-US From: Daniel Engberg In-Reply-To: <202502131256.51DCuHsw011380@gitrepo.freebsd.org> This is a multi-part message in MIME format. --------------v1ed3z0SrQXG7wvPYBffAVjt Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-02-13 13:56, Jason E. Hale wrote: > The branch main has been updated by jhale: > > URL:https://cgit.FreeBSD.org/ports/commit/?id=a77030fc2ead68b333afa5ab4f283de1ed78da1c > > commit a77030fc2ead68b333afa5ab4f283de1ed78da1c > Author: Jason E. Hale > AuthorDate: 2025-02-13 12:48:41 +0000 > Commit: Jason E. Hale > CommitDate: 2025-02-13 12:56:11 +0000 > > graphics/exiv2: Update to 0.28.4 > > Pet portclippy(1) a bit. > > Automate shared library version updates in pkg-plist. > > https://github.com/Exiv2/exiv2/releases/tag/v0.28.4 > --- > graphics/exiv2/Makefile | 14 ++++++++++---- > graphics/exiv2/distinfo | 6 +++--- > graphics/exiv2/pkg-plist | 4 ++-- > 3 files changed, 15 insertions(+), 9 deletions(-) > > diff --git a/graphics/exiv2/Makefile b/graphics/exiv2/Makefile > index e3399ce4731d..deff9e1cdfde 100644 > --- a/graphics/exiv2/Makefile > +++ b/graphics/exiv2/Makefile > @@ -1,6 +1,6 @@ > PORTNAME= exiv2 > DISTVERSIONPREFIX= v > -DISTVERSION= 0.28.3 > +DISTVERSION= 0.28.4 > PORTEPOCH= 1 > CATEGORIES= graphics > > @@ -17,19 +17,25 @@ LIB_DEPENDS= libbrotlidec.so:archivers/brotli \ > > USES= cmake compiler:c++17-lang cpe dos2unix gettext-tools iconv \ > localbase:ldflags pathfix shebangfix > -DOS2UNIX_FILES= cmake/compilerFlags.cmake > -SHEBANG_FILES= fuzz/mkdictionary.py tests/runner.py > USE_LDCONFIG= yes > > USE_GITHUB= yes > GH_ACCOUNT= Exiv2 > > +DOS2UNIX_FILES= cmake/compilerFlags.cmake > + > +SHEBANG_FILES= fuzz/mkdictionary.py \ > + tests/runner.py > + > CMAKE_ON= EXIV2_ENABLE_VIDEO > CMAKE_OFF= EXIV2_ENABLE_EXTERNAL_XMP > > LDFLAGS_mips= -lintl > LDFLAGS_mips64= -lintl > > +PLIST_SUB= SOVER=${DISTVERSION:R:E} \ > + SOVERSION=${DISTVERSION} > + > OPTIONS_DEFINE= DOCS DOXYGEN NLS SAMPLE TEST > OPTIONS_SUB= yes > > @@ -46,12 +52,12 @@ NLS_CMAKE_BOOL= EXIV2_ENABLE_NLS > > SAMPLE_CMAKE_BOOL= EXIV2_BUILD_SAMPLES > > +TEST_IMPLIES= SAMPLE > TEST_BUILD_DEPENDS= googletest>0:devel/googletest > TEST_TEST_DEPENDS= bash:shells/bash > TEST_USES= python:build,test > TEST_CMAKE_BOOL= EXIV2_BUILD_UNIT_TESTS > TEST_CMAKE_ON= -DPython${PYTHON_MAJOR_VER}_EXECUTABLE:FILEPATH="${PYTHON_CMD}" > TEST_TEST_TARGET= test > -TEST_IMPLIES= SAMPLE > > .include > diff --git a/graphics/exiv2/distinfo b/graphics/exiv2/distinfo > index cd05244fa7e7..051be07df099 100644 > --- a/graphics/exiv2/distinfo > +++ b/graphics/exiv2/distinfo > @@ -1,3 +1,3 @@ > -TIMESTAMP = 1725693241 > -SHA256 (Exiv2-exiv2-v0.28.3_GH0.tar.gz) = 1315e17d454bf4da3cc0edb857b1d2c143670f3485b537d0f946d9ed31d87b70 > -SIZE (Exiv2-exiv2-v0.28.3_GH0.tar.gz) = 46480702 > +TIMESTAMP = 1739446777 > +SHA256 (Exiv2-exiv2-v0.28.4_GH0.tar.gz) = 65cb3a813f34fb6db7a72bba3fc295dd6c419082d2d8bbf96518be6d1024b784 > +SIZE (Exiv2-exiv2-v0.28.4_GH0.tar.gz) = 46932087 > diff --git a/graphics/exiv2/pkg-plist b/graphics/exiv2/pkg-plist > index 1e0a93bda246..00e7fef49d17 100644 > --- a/graphics/exiv2/pkg-plist > +++ b/graphics/exiv2/pkg-plist > @@ -66,8 +66,8 @@ lib/cmake/exiv2/exiv2ConfigVersion.cmake > lib/cmake/exiv2/exiv2Export-%%CMAKE_BUILD_TYPE%%.cmake > lib/cmake/exiv2/exiv2Export.cmake > lib/libexiv2.so > -lib/libexiv2.so.0.28.3 > -lib/libexiv2.so.28 > +lib/libexiv2.so.%%SOVERSION%% > +lib/libexiv2.so.%%SOVER%% > libdata/pkgconfig/exiv2.pc > %%NLS%%share/locale/bs/LC_MESSAGES/exiv2.mo > %%NLS%%share/locale/ca/LC_MESSAGES/exiv2.mo Hi, Please review what portclippy actually suggests as this is not syntax Porters Handbook states (and some suggestions are bad at best). Please revert layout changes. https://docs.freebsd.org/en/books/porters-handbook/book/#uses-shebangfix https://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-automatic-replacements Best regards, Daniel --------------v1ed3z0SrQXG7wvPYBffAVjt Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
On 2025-02-13 13:56, Jason E. Hale wrote:
The branch main has been updated by jhale:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a77030fc2ead68b333afa5ab4f283de1ed78da1c

commit a77030fc2ead68b333afa5ab4f283de1ed78da1c
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2025-02-13 12:48:41 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2025-02-13 12:56:11 +0000

    graphics/exiv2: Update to 0.28.4
    
    Pet portclippy(1) a bit.
    
    Automate shared library version updates in pkg-plist.
    
    https://github.com/Exiv2/exiv2/releases/tag/v0.28.4
---
 graphics/exiv2/Makefile  | 14 ++++++++++----
 graphics/exiv2/distinfo  |  6 +++---
 graphics/exiv2/pkg-plist |  4 ++--
 3 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/graphics/exiv2/Makefile b/graphics/exiv2/Makefile
index e3399ce4731d..deff9e1cdfde 100644
--- a/graphics/exiv2/Makefile
+++ b/graphics/exiv2/Makefile
@@ -1,6 +1,6 @@
 PORTNAME=	exiv2
 DISTVERSIONPREFIX=	v
-DISTVERSION=	0.28.3
+DISTVERSION=	0.28.4
 PORTEPOCH=	1
 CATEGORIES=	graphics
 
@@ -17,19 +17,25 @@ LIB_DEPENDS=	libbrotlidec.so:archivers/brotli \
 
 USES=		cmake compiler:c++17-lang cpe dos2unix gettext-tools iconv \
 		localbase:ldflags pathfix shebangfix
-DOS2UNIX_FILES=	cmake/compilerFlags.cmake
-SHEBANG_FILES=	fuzz/mkdictionary.py tests/runner.py
 USE_LDCONFIG=	yes
 
 USE_GITHUB=	yes
 GH_ACCOUNT=	Exiv2
 
+DOS2UNIX_FILES=	cmake/compilerFlags.cmake
+
+SHEBANG_FILES=	fuzz/mkdictionary.py \
+		tests/runner.py
+
 CMAKE_ON=	EXIV2_ENABLE_VIDEO
 CMAKE_OFF=	EXIV2_ENABLE_EXTERNAL_XMP
 
 LDFLAGS_mips=	-lintl
 LDFLAGS_mips64=	-lintl
 
+PLIST_SUB=	SOVER=${DISTVERSION:R:E} \
+		SOVERSION=${DISTVERSION}
+
 OPTIONS_DEFINE=	DOCS DOXYGEN NLS SAMPLE TEST
 OPTIONS_SUB=	yes
 
@@ -46,12 +52,12 @@ NLS_CMAKE_BOOL=	EXIV2_ENABLE_NLS
 
 SAMPLE_CMAKE_BOOL=	EXIV2_BUILD_SAMPLES
 
+TEST_IMPLIES=		SAMPLE
 TEST_BUILD_DEPENDS=	googletest>0:devel/googletest
 TEST_TEST_DEPENDS=	bash:shells/bash
 TEST_USES=		python:build,test
 TEST_CMAKE_BOOL=	EXIV2_BUILD_UNIT_TESTS
 TEST_CMAKE_ON=		-DPython${PYTHON_MAJOR_VER}_EXECUTABLE:FILEPATH="${PYTHON_CMD}"
 TEST_TEST_TARGET=	test
-TEST_IMPLIES=		SAMPLE
 
 .include <bsd.port.mk>
diff --git a/graphics/exiv2/distinfo b/graphics/exiv2/distinfo
index cd05244fa7e7..051be07df099 100644
--- a/graphics/exiv2/distinfo
+++ b/graphics/exiv2/distinfo
@@ -1,3 +1,3 @@
-TIMESTAMP = 1725693241
-SHA256 (Exiv2-exiv2-v0.28.3_GH0.tar.gz) = 1315e17d454bf4da3cc0edb857b1d2c143670f3485b537d0f946d9ed31d87b70
-SIZE (Exiv2-exiv2-v0.28.3_GH0.tar.gz) = 46480702
+TIMESTAMP = 1739446777
+SHA256 (Exiv2-exiv2-v0.28.4_GH0.tar.gz) = 65cb3a813f34fb6db7a72bba3fc295dd6c419082d2d8bbf96518be6d1024b784
+SIZE (Exiv2-exiv2-v0.28.4_GH0.tar.gz) = 46932087
diff --git a/graphics/exiv2/pkg-plist b/graphics/exiv2/pkg-plist
index 1e0a93bda246..00e7fef49d17 100644
--- a/graphics/exiv2/pkg-plist
+++ b/graphics/exiv2/pkg-plist
@@ -66,8 +66,8 @@ lib/cmake/exiv2/exiv2ConfigVersion.cmake
 lib/cmake/exiv2/exiv2Export-%%CMAKE_BUILD_TYPE%%.cmake
 lib/cmake/exiv2/exiv2Export.cmake
 lib/libexiv2.so
-lib/libexiv2.so.0.28.3
-lib/libexiv2.so.28
+lib/libexiv2.so.%%SOVERSION%%
+lib/libexiv2.so.%%SOVER%%
 libdata/pkgconfig/exiv2.pc
 %%NLS%%share/locale/bs/LC_MESSAGES/exiv2.mo
 %%NLS%%share/locale/ca/LC_MESSAGES/exiv2.mo

Hi,

Please review what portclippy actually suggests as this is not syntax Porters Handbook states (and some suggestions are bad at best). Please revert layout changes.

https://docs.freebsd.org/en/books/porters-handbook/book/#uses-shebangfix

https://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-automatic-replacements

Best regards,

Daniel

--------------v1ed3z0SrQXG7wvPYBffAVjt--