Re: git: 7171c7f8895a - main - sysutils/htop: update to 3.3.0

From: Nuno Teixeira <eduardo_at_freebsd.org>
Date: Mon, 12 Feb 2024 08:25:37 UTC
It was discussed a long time ago and portlint was changed to follow it:

if ($_ =~ m|\.desktop$| && $makevar{USES} !~ /\bdesktop-file-utils\b/) {
                        &perror("WARN", $file, $., "this port installs
.desktop files. ".
                                "If the .desktop file(s) installed
contain ``MimeType='', ".
                                "you must add `desktop-file-utils` to USES.");

Fernando Apesteguía <fernape@freebsd.org> escreveu (domingo,
11/02/2024 à(s) 21:29):
>
>
>
> El dom, 11 feb 2024, 20:28, Nuno Teixeira <eduardo@freebsd.org> escribió:
>>
>> It is, but maybe not in the best place/section:
>>
>> https://docs.freebsd.org/en/books/porters-handbook/book/#updating-desktop-database
>
>
> Not quite in my opinion. That says that if the .desktop contains MimeType then desktop-file-utilsshould be used. It doesn't say that *only in that case* it should be used.
>
>>
>>
>> Fernando Apesteguía <fernape@freebsd.org> escreveu (domingo,
>> 11/02/2024 à(s) 18:48):
>> >
>> >
>> >
>> > On Sun, Feb 11, 2024 at 6:31 PM Nuno Teixeira <eduardo@freebsd.org> wrote:
>> >>
>> >> > -USES=          autoreconf compiler:c11 cpe libtool localbase ncurses pkgconfig \
>> >> > -               python:build shebangfix
>> >> > +USES=          autoreconf compiler:c11 cpe desktop-file-utils libtool localbase \
>> >> > +               ncurses pkgconfig python:build shebangfix
>> >>
>> >> desktop-file-utils only needed when .desktop file includes MimeType.
>> >
>> >
>> > I think this comment would be good in the documentation (https://docs.freebsd.org/en/books/porters-handbook/book/#uses-desktop-file-utils)
>> >
>> >>
>> >>
>> >> --
>> >> Nuno Teixeira
>> >> FreeBSD Committer (ports)
>>
>>
>>
>> --
>> Nuno Teixeira
>> FreeBSD Committer (ports)



-- 
Nuno Teixeira
FreeBSD Committer (ports)