From nobody Mon Feb 12 08:25:37 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TYHbK5x5xz59JDy; Mon, 12 Feb 2024 08:25:49 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TYHbK5JdCz49Dy; Mon, 12 Feb 2024 08:25:49 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707726349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BnHHFHkMm1XwcZhkoaSWnA9rzkjuLHC8MZgNb6oPDjA=; b=UDpI4ChOvr2qZir4sjE7w5jUogmJ6l2+dYEDBE4EahTqrEgqwVoF8YKJM1jatl0iuiaPXb cQY96lzTI54tJGbTSdR8bxbUG/fWNNP+c4GGafNEq+V8lLpdjWPMWXCTEzXndJnB2oIaQ8 uqH52k5qapDctHnYPhKRWeG2uHqC/SB0CdUI+U9pkJM06060ZJs4tXJwvWPFtg4tY7eMLh Cj1n0OUJ02GJZwhPl4+TTijpZryLspcQ5gPPC4I02rMQjx4nVReugB6gtF6n6f1zy1dOpR tUw9wtztkOo+Gd0UgjOncNV4PPUFbyjrGNHMyQB3FKn4ln72Z5kQfYxKA++ZLw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1707726349; a=rsa-sha256; cv=none; b=f/BfvzCRz4limq9X8wLARHk7P8s9lx3VN8Pum2IQxNqqIOOMD9oDVPRV1QWBI9z00gjVJk M4Z5EN+2K8XwIVg4Ivl3ua5Wrgsn+CGiKbImLo4SWcw/CicBvWtcyJyD/YtB9S4hREMcPC uNvxzmkoDMKDrI/D93sBgDcXK1XJbvj+PunDjT5WVgm3BczLXfup9EstoVtBdHzM0NkOKA 0CY2yU9qCxScfwAguL4BT+TmCCC2a1h3gFvjyRoWGMXFuBQmwl5VOJCkEcD8fe8VhV/xXp se1JTEIpw4PWSSdY9QZJX9Ea0zjNf3CJKogE543NSm5iEDs21/OGyjO1jGUKbw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707726349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BnHHFHkMm1XwcZhkoaSWnA9rzkjuLHC8MZgNb6oPDjA=; b=vYd2rptnXdQD8aIu43swLzTj5jkhsFVCSA1109Yn0sPVthqd3SQd1XLCB1kH6EqSdgxWaT Iph53Yy8eshO8vuW6Pk4O8xArbv05JBIi5mMDDUekBBpZCkRXDYEIlP9OctDxJCgt63gK/ s16TMuDlsxpm2qzVl9Al2GrmCwj8R0fGX1MgKvyDxkbOAkBrPeBL+U0njUHtrvmzRHGvbF vDvGIimpeBcCmxIb3rtjDLov93i/38ClXqwR8uXtcwnqT2Ksk5O+aSm0pGsmFE1L70+poZ rrm3Fy9AE5Fw3jCRjdtUoJnv/XpFzuWeldJDoJn2VKTEFe+OqCKqpZg5BMtRkA== Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TYHbK4DzgzJKS; Mon, 12 Feb 2024 08:25:49 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3bbbc6e51d0so2236721b6e.3; Mon, 12 Feb 2024 00:25:49 -0800 (PST) X-Gm-Message-State: AOJu0YxGQXUYMuXj2XBLf1EsdSUdj91Qw7t2oCLoOELuj8hkc+Li1ygs vCkgWcYTfdyLVkmUECGYma7t5p8uCt8mX6JGJ8nbH2aosjrFMn6cOQX0OBxen51ko8yRgmgqxx7 9jkJzEvbZ96BiZR+1qcPaBpGuZVU= X-Google-Smtp-Source: AGHT+IGmiRrXooJnIu7xMpBHTYVNxBLqe1MVXUwawmcThWOdabDcPXUqn6NGDl3BfjSxz2dzLt67rOf6tSK6QI3UEOg= X-Received: by 2002:a05:6808:1446:b0:3bf:ded4:2d15 with SMTP id x6-20020a056808144600b003bfded42d15mr7567881oiv.50.1707726348504; Mon, 12 Feb 2024 00:25:48 -0800 (PST) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202402081651.418GplWm053715@gitrepo.freebsd.org> In-Reply-To: From: Nuno Teixeira Date: Mon, 12 Feb 2024 08:25:37 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 7171c7f8895a - main - sysutils/htop: update to 3.3.0 To: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Cc: "ports-committers@FreeBSD.org" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable It was discussed a long time ago and portlint was changed to follow it: if ($_ =3D~ m|\.desktop$| && $makevar{USES} !~ /\bdesktop-file-utils\b/) { &perror("WARN", $file, $., "this port installs .desktop files. ". "If the .desktop file(s) installed contain ``MimeType=3D'', ". "you must add `desktop-file-utils` to USES.= "); Fernando Apestegu=C3=ADa escreveu (domingo, 11/02/2024 =C3=A0(s) 21:29): > > > > El dom, 11 feb 2024, 20:28, Nuno Teixeira escribi= =C3=B3: >> >> It is, but maybe not in the best place/section: >> >> https://docs.freebsd.org/en/books/porters-handbook/book/#updating-deskto= p-database > > > Not quite in my opinion. That says that if the .desktop contains MimeType= then desktop-file-utilsshould be used. It doesn't say that *only in that c= ase* it should be used. > >> >> >> Fernando Apestegu=C3=ADa escreveu (domingo, >> 11/02/2024 =C3=A0(s) 18:48): >> > >> > >> > >> > On Sun, Feb 11, 2024 at 6:31=E2=80=AFPM Nuno Teixeira wrote: >> >> >> >> > -USES=3D autoreconf compiler:c11 cpe libtool localbase ncu= rses pkgconfig \ >> >> > - python:build shebangfix >> >> > +USES=3D autoreconf compiler:c11 cpe desktop-file-utils li= btool localbase \ >> >> > + ncurses pkgconfig python:build shebangfix >> >> >> >> desktop-file-utils only needed when .desktop file includes MimeType. >> > >> > >> > I think this comment would be good in the documentation (https://docs.= freebsd.org/en/books/porters-handbook/book/#uses-desktop-file-utils) >> > >> >> >> >> >> >> -- >> >> Nuno Teixeira >> >> FreeBSD Committer (ports) >> >> >> >> -- >> Nuno Teixeira >> FreeBSD Committer (ports) --=20 Nuno Teixeira FreeBSD Committer (ports)