Re: git: 3fd626858d82 - 2023Q1 - devel/rgbds: Fix build on 12.4

From: Gerald Pfeifer <gerald_at_pfeifer.com>
Date: Tue, 28 Mar 2023 22:45:53 UTC 
On Tue, 28 Mar 2023, Nuno Teixeira wrote:
> I can use clang 10 on this port until problem is resolved but is it a good
> idea to use an old clang compiler instead of a newer gcc one?

What happens if a newer version of GCC starts issuing an error, too?

Then an ungrade to that newer version will be blocked due to this port
regressing or at least make it much harder and require forcing an older
version of GCC.

On Tue, 28 Mar 2023, Alexey Dokuchaev wrote:
> It builds fine for me with default compiler (12.4/13.1) and this target:
> 
> post-patch:
> # yank _POSIX_C_SOURCE because it breaks the build
> 	${REINPLACE_CMD} 's,-D_POSIX_C_SOURCE=200809L,,' ${WRKSRC}/Makefile

Cool, thank you danfe!

On Tue, 28 Mar 2023, Nuno Teixeira wrote:
> Thank you so much! I did test it without _POSIX_C_SOURCE but it failed 
> at first because I did a mistake on reinplace cmd. It builds fine now.

And thanks for the port update, Nuno!

Gerald