From nobody Tue Mar 28 22:45:53 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PmPsw6slSz42Xl3; Tue, 28 Mar 2023 22:45:56 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PmPsw59vgz3LpZ; Tue, 28 Mar 2023 22:45:56 +0000 (UTC) (envelope-from gerald@pfeifer.com) Authentication-Results: mx1.freebsd.org; none Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id B783333E4C; Tue, 28 Mar 2023 18:45:55 -0400 (EDT) Received: from [192.168.1.80] (62-47-129-209.adsl.highway.telekom.at [62.47.129.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id C996E33E4B; Tue, 28 Mar 2023 18:45:54 -0400 (EDT) Date: Wed, 29 Mar 2023 00:45:53 +0200 (CEST) From: Gerald Pfeifer To: Nuno Teixeira , Alexey Dokuchaev cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-branches@freebsd.org Subject: Re: git: 3fd626858d82 - 2023Q1 - devel/rgbds: Fix build on 12.4 In-Reply-To: Message-ID: <3f74af30-6c60-fb45-ca64-4a534e30edd9@pfeifer.com> References: <202303130836.32D8a39n017978@gitrepo.freebsd.org> <6174ccaf-95ae-ae15-9ce2-a4c143154d06@pfeifer.com> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: mailmunge 3.11 on 209.68.5.143 X-Rspamd-Queue-Id: 4PmPsw59vgz3LpZ X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Tue, 28 Mar 2023, Nuno Teixeira wrote: > I can use clang 10 on this port until problem is resolved but is it a good > idea to use an old clang compiler instead of a newer gcc one? What happens if a newer version of GCC starts issuing an error, too? Then an ungrade to that newer version will be blocked due to this port regressing or at least make it much harder and require forcing an older version of GCC. On Tue, 28 Mar 2023, Alexey Dokuchaev wrote: > It builds fine for me with default compiler (12.4/13.1) and this target: > > post-patch: > # yank _POSIX_C_SOURCE because it breaks the build > ${REINPLACE_CMD} 's,-D_POSIX_C_SOURCE=200809L,,' ${WRKSRC}/Makefile Cool, thank you danfe! On Tue, 28 Mar 2023, Nuno Teixeira wrote: > Thank you so much! I did test it without _POSIX_C_SOURCE but it failed > at first because I did a mistake on reinplace cmd. It builds fine now. And thanks for the port update, Nuno! Gerald