Re: git: dafb3cafaf77 - main - editors/ghostwriter: Fix Makefile causing errors
- In reply to: Alexey Dokuchaev : "Re: git: dafb3cafaf77 - main - editors/ghostwriter: Fix Makefile causing errors"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 16 Jan 2023 08:29:39 UTC
On 16/01/23 09:07, Alexey Dokuchaev wrote:
> On Sun, Jan 15, 2023 at 11:30:33PM +0000, Guido Falsi wrote:
>> commit dafb3cafaf774e89c3ebd1500ce56fba5665da02
>>
>> editors/ghostwriter: Fix Makefile causing errors
>>
>> Using FLAVOR?=${FLAVORS:[0]} confuses the ports make system.
>
> :[0] returns the whole string (after expansion), word enumeration
> starts with one. I don't see where does confusion come from, just
> use FLAVORS:[1] as documented in man make(1). Ideally it can be
> dropped altogether (default flavor is set by b.p.m.) but since this
> definition is not available immediately, it requires certain care.\
Yes thanks! I actually know this, but yesterday evening, when I
performed this commit I was clearly tired and my mind simply overlooked
this detail. Most probably I got confused with the usual array syntax in
almost any other programming language I know.
--
Guido Falsi <madpilot@FreeBSD.org>